Skip to content

Commit eb869cf

Browse files
committed
feat(app): echo declared browser origins in run show and the run detail view
Rebased on latest main to resolve conflicts with #542 merge.
1 parent 35ef0a9 commit eb869cf

8 files changed

Lines changed: 116 additions & 0 deletions

File tree

‎docs/openapi.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60916,6 +60916,12 @@
6091660916
"RunConfigView": {
6091760917
"additionalProperties": false,
6091860918
"properties": {
60919+
"browser_origins": {
60920+
"items": {
60921+
"type": "string"
60922+
},
60923+
"type": "array"
60924+
},
6091960925
"continuity_context_fingerprint": {
6092060926
"type": "string"
6092160927
},
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# Browser origins 配置可见性(ADR 0195 Phase 4 收尾片):OCR delegate 复审
2+
3+
日期:2026-11-06。基线:`5bbdc2b2`(PR #542 分支,live view 投影)。
4+
主题:#542 评审 P3 跟进的落实——操作者声明的 origins 在配置面的回显:
5+
`run show` 条件输出 `browser_origins: <逗号列表>`(声明为空不打印,与
6+
started_at/finished_at 的条件输出风格一致);HTTP `RunDetailView.run.config`
7+
暴露 `browser_origins`(omitempty,RunDetailView→RunView→RunConfigView 反射
8+
自动传播);openapi/schema.d.ts 生成器再生成;`TestRunViewCarriesBrowserOrigins`
9+
单测(scoped/unscoped)+ CLI run show 回显断言并入既有 browser-origins 测试。
10+
11+
## 覆盖范围
12+
13+
6 文件:`internal/app/run_command.go`、`run_command_test.go`、
14+
`internal/httpapi/views.go`、`agent_browser_test.go`、`docs/openapi.json`、
15+
`web/src/api/schema.d.ts`。
16+
17+
## 发现与处置(评审子代理报告)
18+
19+
| 级别 | 内容 | 处置 |
20+
| --- | --- | --- |
21+
| P3 | run 详情 UI 可选展示 origins(API 已就绪;live view 已有现成 i18n 文案)。 | 记为后续跟进,不阻塞。 |
22+
| P3 | run list API 响应自动携带 origins(RunConfigView 被 list/detail 共用)。 | 无需处理(omitempty、≤8 条短串);未来列表 payload 精简时再拆 view。 |
23+
| 提醒 | 提交前建分支。 | 已按提醒执行。 |
24+
25+
评审确认(无 P0/P1/P2):run show 断言均为 Contains、无 golden 破坏;origins 是
26+
操作者自己的授权声明、不属于隐私类别(隐私测试实跑通过);fork/resume/branch
27+
不继承的真正机制在创建侧(CreateRunRequest 不传)而非 runView;import 块修复后
28+
字母序正确;再生成 diff 只含该字段(传播链 RunDetailView→$ref RunView→config→
29+
$ref RunConfigView);run list 共用 view 的影响可忽略。run 详情 UI 展示记为
30+
后续跟进。
31+
32+
## 验证
33+
34+
- `go build ./...`、`go vet ./internal/app/ ./internal/httpapi/`;定向测试:
35+
CLI(创建成功/run show 回显/私网拒绝/超限拒绝)、`TestRunViewCarriesBrowserOrigins`、
36+
httpapi 全包(237s)全绿。
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
{
2+
"schema_version": "1",
3+
"mode": "ocr_delegate",
4+
"base": "5bbdc2b2",
5+
"reviewed_head": "feat/browser-origin-visibility staged diff",
6+
"review_metadata_excluded": [
7+
"docs/reviews/browser-origin-visibility/README.md"
8+
],
9+
"reviewers": [
10+
"主 agent:切片实现与自审",
11+
"review_delegate:六项专项核对(输出契约/安全面/import 修复/测试真实性/再生成完整性/消费方排查),无阻塞发现"
12+
],
13+
"summary": {
14+
"total_git_changed_files": 6,
15+
"review_scope_files": 6,
16+
"review_metadata_excluded_count": 1,
17+
"unread_in_scope": 0,
18+
"coverage_rate": 1.0
19+
},
20+
"files": [
21+
{
22+
"path": "internal/app/run_command.go",
23+
"coverage": "full",
24+
"reviewer": "primary_and_delegate"
25+
},
26+
{
27+
"path": "internal/app/run_command_test.go",
28+
"coverage": "full",
29+
"reviewer": "primary_and_delegate"
30+
},
31+
{
32+
"path": "internal/httpapi/views.go",
33+
"coverage": "full",
34+
"reviewer": "primary_and_delegate"
35+
},
36+
{
37+
"path": "internal/httpapi/agent_browser_test.go",
38+
"coverage": "full",
39+
"reviewer": "primary_and_delegate"
40+
},
41+
{
42+
"path": "docs/openapi.json",
43+
"coverage": "generated",
44+
"reviewer": "primary_and_delegate"
45+
},
46+
{
47+
"path": "web/src/api/schema.d.ts",
48+
"coverage": "generated",
49+
"reviewer": "primary_and_delegate"
50+
}
51+
]
52+
}

‎internal/app/run_command.go‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1939,6 +1939,9 @@ func (a *App) runShow(ctx context.Context, service *application.RunService, args
19391939
run.ID, mission.ID, run.Status, mission.Goal, mission.Profile, mode.Surface,
19401940
mode.Phase, mode.Revision, mode.PolicyVersion, mission.WorkspaceID, run.SessionID,
19411941
run.Config.ModelRoute, run.Config.Interactive, scope, budget, run.CreatedAt.Format(time.RFC3339), run.UpdatedAt.Format(time.RFC3339))
1942+
if len(run.Config.BrowserOrigins) != 0 {
1943+
fmt.Fprintf(a.out, "browser_origins: %s\n", strings.Join(run.Config.BrowserOrigins, ", "))
1944+
}
19421945
if run.StartedAt != nil {
19431946
fmt.Fprintf(a.out, "started_at: %s\n", run.StartedAt.Format(time.RFC3339))
19441947
}

‎internal/app/run_command_test.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,6 +1722,10 @@ func TestRunCreateAcceptsBrowserOriginsAndFailsClosed(t *testing.T) {
17221722
if code != 0 || stderr != "" {
17231723
t.Fatalf("scoped create stdout=%s stderr=%s code=%d", created, stderr, code)
17241724
}
1725+
shown, stderr, code := executeTestCommand(t, "run", "show", runIDPattern.FindString(created))
1726+
if code != 0 || stderr != "" || !strings.Contains(shown, "browser_origins: http://localhost:3000, https://example.com:443") {
1727+
t.Fatalf("run show must echo the declared origins: output=%s stderr=%s code=%d", shown, stderr, code)
1728+
}
17251729
if _, stderr, code = executeTestCommand(t, "run", "create",
17261730
"out of policy", "--profile", "code", "--surface", "code",
17271731
"--phase", "plan", "--browser-origin", "http://192.168.1.5"); code == 0 || !strings.Contains(stderr, "browser origins fail-closed") {

‎internal/httpapi/agent_browser_test.go‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
"cyberagent-workbench/internal/apperror"
1818
"cyberagent-workbench/internal/application"
1919
"cyberagent-workbench/internal/browserruntime"
20+
"cyberagent-workbench/internal/domain"
2021
"cyberagent-workbench/internal/webevidence"
2122
)
2223

@@ -361,3 +362,14 @@ func TestAgentBrowserStatusSurfacesDeclaredOrigins(t *testing.T) {
361362
t.Fatalf("unscoped session must omit declared origins: %+v", unscoped.DeclaredOrigins)
362363
}
363364
}
365+
366+
func TestRunViewCarriesBrowserOrigins(t *testing.T) {
367+
scoped := runView(domain.Run{ID: "run-origins", Config: domain.RunConfig{BrowserOrigins: []string{"https://example.org:443"}}})
368+
if len(scoped.Config.BrowserOrigins) != 1 || scoped.Config.BrowserOrigins[0] != "https://example.org:443" {
369+
t.Fatalf("run view must carry the declared origins: %+v", scoped.Config.BrowserOrigins)
370+
}
371+
unscoped := runView(domain.Run{ID: "run-plain"})
372+
if len(unscoped.Config.BrowserOrigins) != 0 {
373+
t.Fatalf("unscoped run view must omit the field: %+v", unscoped.Config.BrowserOrigins)
374+
}
375+
}

‎internal/httpapi/views.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -702,6 +702,7 @@ type RunConfigView struct {
702702
RequestedBudget *domain.Budget `json:"requested_budget,omitempty"`
703703
ModelRoute string `json:"model_route"`
704704
Interactive bool `json:"interactive"`
705+
BrowserOrigins []string `json:"browser_origins,omitempty"`
705706
ProjectConfigFingerprint string `json:"project_config_fingerprint,omitempty"`
706707
ProjectInstructionsFingerprint string `json:"project_instructions_fingerprint,omitempty"`
707708
ContinuityContextFingerprint string `json:"continuity_context_fingerprint,omitempty"`
@@ -1685,6 +1686,7 @@ func runView(value domain.Run) RunView {
16851686
return RunView{
16861687
ID: value.ID, MissionID: value.MissionID, SessionID: value.SessionID, Status: string(value.Status),
16871688
Config: RunConfigView{ModelRoute: value.Config.ModelRoute, Interactive: value.Config.Interactive, RequestedBudget: value.Config.RequestedBudget,
1689+
BrowserOrigins: append([]string(nil), value.Config.BrowserOrigins...),
16881690
ProjectConfigFingerprint: value.Config.ProjectConfigFingerprint,
16891691
ProjectInstructionsFingerprint: value.Config.ProjectInstructionsFingerprint,
16901692
ContinuityContextFingerprint: value.Config.ContinuityContextFingerprint},

‎web/src/api/schema.d.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12387,6 +12387,7 @@ export interface components {
1238712387
ui_evidence: components["schemas"]["VerificationFeatureReadinessView"];
1238812388
};
1238912389
RunConfigView: {
12390+
browser_origins?: string[];
1239012391
continuity_context_fingerprint?: string;
1239112392
interactive: boolean;
1239212393
model_route: string;

0 commit comments

Comments
 (0)