ci: run checks on PRs to feat/** and test vmm UI and vmm-cli (#1559)

* ci: run checks on PRs to feat/** and test vmm UI and vmm-cli

PRs targeting feature branches only got the Foundry checks. Also fail the
Rust job when cryptsetup is missing so the LUKS tests cannot silently skip.

Signed-off-by: Kevin Wang <wy721@qq.com>

* ci: check auth-eth-bun on feature branch PRs and fix the vmm-cli deps

cryptography 50.0.0 needs cffi 2.0.0 or later, so requirements.txt could
not be installed with cffi pinned to 1.17.1. The file exists on every
branch, so install it unconditionally.

Signed-off-by: Kevin Wang <wy721@qq.com>

---------

Signed-off-by: Kevin Wang <wy721@qq.com>

Author: kvinwang

.github/workflows/kms-auth-eth-bun.yml

@@ -24,7 +24,7 @@ on:
       - 'dstack/kms/auth-eth-bun/**'
       - '.github/workflows/kms-auth-eth-bun.yml'
   pull_request:
-    branches: [ next, 'release/**' ]
+    branches: [ next, 'release/**', 'feat/**' ]
     paths:
       - 'dstack/kms/auth-eth-bun/**'
       - '.github/workflows/kms-auth-eth-bun.yml'

.github/workflows/prek-check.yml

@@ -8,7 +8,7 @@ on:
   push:
     branches: [ next, 'release/**' ]
   pull_request:
-    branches: [ next, 'release/**' ]
+    branches: [ next, 'release/**', 'feat/**' ]
 
 permissions:
   contents: read

.github/workflows/rust.yml

@@ -8,7 +8,7 @@ on:
   push:
     branches: [ next, 'release/**' ]
   pull_request:
-    branches: [ next, 'release/**' ]
+    branches: [ next, 'release/**', 'feat/**' ]
 
 env:
   CARGO_TERM_COLOR: always
@@ -78,6 +78,12 @@ jobs:
       if: steps.changes.outputs.relevant == 'true'
       run: cargo fmt --check --all
 
+    # The LUKS tests in dstack-util skip and pass when cryptsetup is missing.
+    # Fail here instead, so a runner without it cannot hide them.
+    - name: Require cryptsetup
+      if: steps.changes.outputs.relevant == 'true'
+      run: cryptsetup --version
+
     - name: Run tests
       if: steps.changes.outputs.relevant == 'true'
       run: ./run-tests.sh

.github/workflows/sdk.yaml

@@ -11,7 +11,7 @@ on:
   push:
     branches: [next, 'release/**']
   pull_request:
-    branches: [next, 'release/**']
+    branches: [next, 'release/**', 'feat/**']
 
 env:
   CARGO_TERM_COLOR: always

.github/workflows/spdx-check.yml

@@ -8,7 +8,7 @@ on:
   push:
     branches: [ next, 'release/**' ]
   pull_request:
-    branches: [ next, 'release/**' ]
+    branches: [ next, 'release/**', 'feat/**' ]
 
 jobs:
   reuse-lint:

.github/workflows/vmm-ui.yml

@@ -7,18 +7,24 @@ name: VMM UI build
 permissions:
   contents: read
 
-# Only the VMM's web UI is built here. Not a required status check, so a
-# workflow-level filter is safe.
+# The VMM's web UI and vmm-cli are built and tested here. Not a required
+# status check, so a workflow-level filter is safe.
 on:
   push:
     branches: [ next, 'release/**' ]
     paths:
       - 'dstack/vmm/ui/**'
+      - 'dstack/vmm/src/vmm-cli.py'
+      - 'dstack/vmm/src/tests/test_vmm_cli.py'
+      - 'dstack/vmm/requirements.txt'
       - '.github/workflows/vmm-ui.yml'
   pull_request:
-    branches: [ next, 'release/**' ]
+    branches: [ next, 'release/**', 'feat/**' ]
     paths:
       - 'dstack/vmm/ui/**'
+      - 'dstack/vmm/src/vmm-cli.py'
+      - 'dstack/vmm/src/tests/test_vmm_cli.py'
+      - 'dstack/vmm/requirements.txt'
       - '.github/workflows/vmm-ui.yml'
 
 jobs:
@@ -47,3 +53,26 @@ jobs:
           git status --porcelain
           exit 1
         fi
+
+    # `--if-present`: the UI test script is not on every branch yet.
+    - name: Test vmm UI
+      run: npm run test --if-present
+      working-directory: dstack/vmm/ui
+
+  vmm-cli:
+    runs-on: ${{ vars.CI_RUNNER || 'ubuntu-latest' }}
+    steps:
+    - uses: actions/checkout@v5
+
+    - name: Install Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: '3.12'
+
+    - name: Install vmm-cli dependencies
+      run: pip install -r requirements.txt
+      working-directory: dstack/vmm
+
+    - name: Test vmm-cli
+      run: python3 -m unittest -v tests/test_vmm_cli.py
+      working-directory: dstack/vmm/src

dstack/vmm/requirements.txt

@@ -1,5 +1,5 @@
 annotated-types==0.7.0
-cffi==1.17.1
+cffi==2.0.0
 cryptography==50.0.0
 cytoolz==1.0.1
 eth-hash==0.7.1