097 crash after pause in rowing

[eglin73]

Hi,

I have experienced a number of instances where 097 stops functioning when resuming rowing after a pause. Initially on resumption the display does not appear to show expected outputs, typically the pace/500 might be way to fast (15-20s per 500 too fast) or not have any metrics. Or the force curve is blank or sometimes very unusual.

This is usually followed by the session ending.

I have attached the log, there are thing it in that might indicate things are not right, but I'm not able to work out what is happening, so would appreciate it if someone could take a look when they have a chance.

Thanks
Ian

May 03 092313 rowingmonitor_log.txt

[JaapvanEkris]

This is an issue I fixed in 0.9.8, but haven't backported it. The fit-recorder sees a huge array for the force curve (stroke detection goes wrong somehow), but somehow misses that it should be trimmed. This crashes the recorder and then the entire app. I guarded for this situation, but somehow the guard doesn't function.

The bugfix is in https://github.com/JaapvanEkris/openrowingmonitor/tree/JaapvanEkris-patch-1

Will backport this at the end of the week.

[eglin73]

Great, thanks Jaap.

[JaapvanEkris]

I think the fix should work, but I can't test right now (away from rowing machines and computers). If someone could test it would be helpfull as I chose another approach with 0.9.8 (as that recorder contains changes that probably break under 0.9.7, I can't copy it). With fitfileviewer.com you can check if all data is passed. Otherwise I'll merge it into main end of the week.

[eglin73]

I tried Jaap, but was unsuccessful. Most likely user error. I tired to add a remote update

cd /opt/openrowingmonitor/
sudo git remote add update https://github.com/JaapvanEkris//openrowingmonitor/tree/JaapvanEkris-patch-1

which seemed to work;

eglin73@rowingmonitor:/opt/openrowingmonitor $ git remote -v
origin https://github.com/JaapvanEkris/openrowingmonitor.git (fetch)
origin https://github.com/JaapvanEkris/openrowingmonitor.git (push)
update https://github.com/JaapvanEkris/openrowingmonitor/tree/JaapvanEkris-patch-1 (fetch)
update https://github.com/JaapvanEkris/openrowingmonitor/tree/JaapvanEkris-patch-1 (push)

but then I got an error that it could not fetch the update

eglin73@rowingmonitor:/opt/openrowingmonitor $ sudo git fetch --all
Fetching origin
remote: Enumerating objects: 329, done.
remote: Counting objects: 100% (275/275), done.
remote: Compressing objects: 100% (223/223), done.
remote: Total 329 (delta 223), reused 53 (delta 52), pack-reused 54 (from 1)
Receiving objects: 100% (329/329), 141.88 KiB | 880.00 KiB/s, done.
Resolving deltas: 100% (247/247), completed with 9 local objects.
From https://github.com/JaapvanEkris/openrowingmonitor
0cd961b..3d71bc0 0.9.8-Backend-TS/Vitest-migration -> origin/0.9.8-Backend-TS/Vitest-migration

• [new branch] JaapvanEkris-patch-1 -> origin/JaapvanEkris-patch-1
• [new branch] fix-ble-crash -> origin/fix-ble-crash
  Fetching update
  fatal: repository 'https://github.com/JaapvanEkris/openrowingmonitor/tree/JaapvanEkris-patch-1/' not found
  error: could not fetch update

[JaapvanEkris]

Our update script can switch branches with the -b option.

[eglin73]

Thanks,

I have been able to do that and am now running the patch-1 branch. I'll try do a couple of rows to test.

rowingmonitor:/opt/openrowingmonitor $ git branch -a

• JaapvanEkris-patch-1
  main

Thanks
Ian

[eglin73]

Just an update, I've not rowed as much the last week, but I've got in 3 decent rows and not seen the issue reoccur since switching to the -patch-1

Thanks
Ian

[JaapvanEkris]

Thanks for reporting back!