Repository navigation
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Jwhiles
marked this pull request as ready for review
November 3, 2026 16:34
Jwhiles
had a problem deploying
to
segment-schema
November 3, 2026 16:34 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Builds ready [c702767]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Matt561
previously approved these changes
Nov 3, 2026
Comment on lines
+8
to
+11
| * It navigates to the Money home, which starts the deposit once the Money | ||
| * account is available. Users who are ineligible for a Money account are | ||
| * redirected to the wallet home by the Money page. | ||
| * - https://link.metamask.io/money-account-deposit |
Contributor
There was a problem hiding this comment.
@Jwhiles is it mandatory that we navigate to Money home first before initiating the deposit? Is it feasible to navigate directly to the Money deposit screen?
I might be missing some extension context!
Contributor
Author
There was a problem hiding this comment.
basically I think we need to have a route for the deposit to open from, since it isn't really a route per se - and the money home makes sense for that.
I think the alternative would be to make something akin to the deeplink bridge that you added to mobile. Happy to do that, but it will make the PR a bit bigger!
Contributor
There was a problem hiding this comment.
Totally up to you @Jwhiles. I'm happy to approve either approach.
Jwhiles
had a problem deploying
to
segment-schema
November 3, 2026 19:55 — with
GitHub Actions
Error
GitHub Actions
Error
Jwhiles
had a problem deploying
to
segment-schema
November 3, 2026 19:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +33 -6)
|
Contributor
Builds ready [611b156]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Matt561
self-requested a review
November 3, 2026 20:22
Matt561
approved these changes
Nov 3, 2026
Jwhiles
had a problem deploying
to
segment-schema
November 4, 2026 09:19 — with
GitHub Actions
Failure
GitHub Actions
Failure
Jwhiles
added
the
retry-ci
Jwhiles
had a problem deploying
to
segment-schema
November 4, 2026 13:32 — with
GitHub Actions
Failure
GitHub Actions
Failure
Jwhiles
had a problem deploying
to
segment-schema
November 4, 2026 14:05 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Builds ready [d46420a]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds money deposit deeplink, to achieve parity with mobile
Changelog
CHANGELOG entry: add money deposit deeplink
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Before
n/a
After
Screen.Recording.2026-11-03.at.16.33.01.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes deposit initiation return values and confirmation history behavior (push vs replace), which can affect navigation from Money flows and external deeplink entry points.
Overview
Adds extension support for
https://link.metamask.io/money-account-deposit, aligned with mobile: a new deep link route (with interstitial protection and copy) resolves to/money-home/deposit, which renders a bridge page that waits for Money account availability, starts a deposit, and sends ineligible users or failed setup to wallet home.useMoneyAccountDepositnow resolves totrue/false(including when a second initiation is ignored), and acceptsreplaceConfirmationand optionalgoBackToso the confirmation can replace the bridge and return to Money home on close.navigateToTransactiongains areplacepath that navigates with{ replace: true }instead of always pushing withgoBackAction=pop.Routing, locale string
deepLink_theMoneyDepositPage, and unit tests cover the new route, bridge page, hook behavior, and confirmation navigation.Reviewed by Cursor Bugbot for commit d46420a. Bugbot is set up for automated code reviews on this repo. Configure here.