You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Medium Risk
Touches authentication MFA flows and analytics consent plumbing, but events exclude codes/secrets and analytics errors cannot block completion.
Overview
Adds Segment-aligned MFA analytics across the MFA kit and extension UI, wired through MetaMetrics under the Auth category.
A new createMfaTracker module emits flow lifecycle events (started / completed / failed / cancelled), step views, inline and failure-screen errors (with grouped error_type), method picks, OTP resends (user vs auto), and error CTAs (try_again, learn_more, contact_support). Each flow gets a stable flow_id plus entry_point, operation, flow_type, and required methods; tracking failures are swallowed so they never affect outcomes. useMfa passes an optional trackEvent hook into startMfaFlow, mapping kit event names to new MetaMetricsEventName entries.
Typing and UX tweaks:MfaReason.operation is now ${MfaEntryPoint}.${string} (tests use qa.test instead of bare test). The code step treats OTP cooldowns as countdowns (no MFA Error Viewed), auto-resend sends trigger: 'auto, and expiry recovery toggles codeResent so the OTP UI clears reliably. MFA step components dispatch errorCtaClicked for retry, support, and learn-more actions.
Reviewed by Cursor Bugbot for commit 40adf54. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2477
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches authentication MFA flows and analytics consent plumbing, but events exclude codes/secrets and analytics errors cannot block completion.
Overview
Adds Segment-aligned MFA analytics across the MFA kit and extension UI, wired through MetaMetrics under the Auth category.
A new
createMfaTrackermodule emits flow lifecycle events (started / completed / failed / cancelled), step views, inline and failure-screen errors (with groupederror_type), method picks, OTP resends (user vs auto), and error CTAs (try_again,learn_more,contact_support). Each flow gets a stableflow_idplusentry_point,operation,flow_type, and required methods; tracking failures are swallowed so they never affect outcomes.useMfapasses an optionaltrackEventhook intostartMfaFlow, mapping kit event names to newMetaMetricsEventNameentries.Typing and UX tweaks:
MfaReason.operationis now${MfaEntryPoint}.${string}(tests useqa.testinstead of baretest). The code step treats OTP cooldowns as countdowns (noMFA Error Viewed), auto-resend sendstrigger: 'auto, and expiry recovery togglescodeResentso the OTP UI clears reliably. MFA step components dispatcherrorCtaClickedfor retry, support, and learn-more actions.Reviewed by Cursor Bugbot for commit 40adf54. Bugbot is set up for automated code reviews on this repo. Configure here.