Repository navigation
fix(perps): align outage banner links with mobile - #47617
michalconsensys wants to merge 3 commits into
Conversation
Point the FAQ at the Perps troubleshoot article and open contact support through the data-consent modal to the help center.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (4 files, +255 -34)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d35bdf9. Configure here.
Builds ready [d35bdf9]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)
Bundle Size Diffs
|
Locale verification requires every locale description to match English.
Builds ready [4cf1e27]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)
Bundle Size Diffs
|
The consent dialog is portaled outside the close-position modal, so its buttons were treated as an outside click and dismissed the flow before support could open.
Builds ready [7d56da3]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|




Description
The Perps outage banner linked “See your options in FAQs” to the Perps help-center hub and “contact support” to the troubleshoot article. Mobile already sends the FAQ to the troubleshoot article and opens contact support through the data-consent flow to the general help center.
This change matches that behavior on extension. The FAQ link opens
https://support.metamask.io/trade/perps/troubleshoot/?utm_source=extensiondirectly. Contact support opens the existing data-sharing consent dialog, thenhttps://support.metamask.io/?utm_source=extension.Changelog
CHANGELOG entry: Fixed Perps outage banner links so the FAQ opens the troubleshoot article and contact support opens the help center.
Related issues
Fixes:
Manual testing steps
The help center may insert a language prefix, such as
/fr/, before the path. Accepting consent appends the usual support account details to the help-center URL.To force the banner on locally, point
MANIFEST_OVERRIDESin.metamaskrcat a file containing:{ "_flags": { "remoteFeatureFlags": { "perpsPerpTradingServiceInterruptionBannerEnabled": true } } }Screenshots/Recordings
Before
https://support.metamask.io/trade/perps/?utm_source=extensionhttps://support.metamask.io/trade/perps/troubleshoot/?utm_source=extensionAfter
https://support.metamask.io/trade/perps/troubleshoot/?utm_source=extensionhttps://support.metamask.io/?utm_source=extensionPre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Changes are limited to Perps outage banner URLs, support consent UX, and modal dismiss handling; no trading, auth, or wallet logic is affected.
Overview
The Perps service interruption banner now matches mobile: the FAQ action opens the troubleshoot article directly, and contact support opens the existing data-sharing consent dialog before the general MetaMask help center (
SUPPORT_CONFIG.Url), instead of swapping those two destinations.SERVICE_INTERRUPTION_CONFIGinshared/constants/perps.tsis updated accordingly, with locale description strings refreshed across languages.The banner’s support control is a click handler plus
VisitSupportDataConsentModalrather than a direct external link.ClosePositionModalwiresonSupportConsentOpenChangeso outside-click dismiss does not close the close-position flow while the portaled consent UI is open. Tests cover the new URLs, consent flow, and modal dismiss behavior.Reviewed by Cursor Bugbot for commit 7d56da3. Bugbot is set up for automated code reviews on this repo. Configure here.