Repository navigation
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (5 files, +383 -0)
|
Contributor
Builds ready [f7cca83]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [9d66552]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
bfullam
marked this pull request as ready for review
November 4, 2026 14:55
bfullam
had a problem deploying
to
segment-schema
November 4, 2026 14:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
bfullam
had a problem deploying
to
segment-schema
November 4, 2026 14:57 — with
GitHub Actions
Failure
GitHub Actions
Failure
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 592d76f. Configure here.
bfullam
had a problem deploying
to
segment-schema
November 4, 2026 15:12 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Builds ready [592d76f]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [63cdc7d]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
GeorgeGkas
approved these changes
Nov 4, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the fee rebate banner, "You’re getting X% back on fees", directly above the CTA button in Swaps. This mirrors Mobile's implementation (metamask-mobile#37623). Users who are eligible for a rebate see what share of the MetaMask fee they'll get back, paid to their Money account.
How it works:
useSwapsRebatehook: callsRewardsMoneyController:getSwapsRebateQuote(already in the extension) with the active quote, through a route messenger that allows only that action.rebateBips / 100, but only wheneligibleis true andreasonis null.SwapsRebateBanner: shows the message, the existingmoney.pngicon, and a "Trading Rewards" info tooltip. It renders nothing when there's no rebate. The tooltip popover is givenzIndex: 20so it paints above the sticky CTA footer.swapsRebateBannerEnabledremote flag ({ enabled, minimumVersion }), the same key Mobile uses. It defaults to off, and when it's off the endpoint isn't called. The flag is registered asinProd: falseinfeature-flag-registry.ts.Changelog
CHANGELOG entry: Added a fee rebate banner to Swaps for users eligible for a MetaMask fee rebate
Related issues
Fixes: SWAPS-5293
Manual testing steps
Until the endpoint returns a rebate for your account, you can force one by temporarily replacing the controller call in
ui/hooks/bridge/useSwapsRebate.tswithPromise.resolve({ eligible: true, rebateBips: 1000, reason: null }).swapsRebateBannerEnabledremote flag, for example in.manifest-overrides.jsonwith{ "enabled": true, "minimumVersion": "0.0.0" }.eligible: falseor an error, and verify that no banner is shown and the swap flow is unchanged.Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Promotional UI behind a remote flag that fails closed; it uses an existing rewards endpoint and does not gate or alter swap execution.
Overview
Adds an optional Trading Rewards banner above the Swaps prepare CTA that tells eligible users what % of the MetaMask fee they’ll get back (paid in mUSD to Money), aligned with Mobile.
The flow is gated by the remote
swapsRebateBannerEnabledflag (defaults off). When enabled,useSwapsRebatecallsRewardsMoneyController:getSwapsRebateQuotevia a scoped route messenger, converts eligiblerebateBipsto a display percentage, and does not block the swap button. Rebates are fetched on mount and only when the MetaMask fee token changes (not on quote refresh); failures or ineligibility hide the banner.SwapsRebateBannerrenders the message, Money icon, and tooltip (with elevated z-index over the sticky footer). New locale strings and unit/component tests cover the hook and banner.Reviewed by Cursor Bugbot for commit 63cdc7d. Bugbot is set up for automated code reviews on this repo. Configure here.