Nightblade Support incorrectly treated as incompatible with Windburst

[ImVexed]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

In game, Windburst can be supported by Nightblade just fine, as seen in the screenshot.

What is the behaviour in Path of Building?

Nightblade Support appears to be treated as incompatible with Windburst, so none of Nightblade's modifiers are applied to Windburst in PoB.

Windburst is an Attack and does not appear to have an intrinsic weapon restriction. Nightblade supports Attack skills and imposes a Claw/Dagger weapon restriction.

With a Claw or Dagger equipped, I would therefore expect Nightblade to support Windburst. Instead, adding/removing Nightblade causes no change to Windburst's calculated stats.

This appears to come from canGrantedEffectSupportActiveSkill() in src/Modules/CalcTools.lua.

Weapon-restricted supports currently appear to require the active skill itself to contain a weaponTypes table:

if grantedEffect.weaponTypes then
    local activeTypeLookup = { }

    if activeSkill.activeEffect.grantedEffect.weaponTypes then
        for activeType in pairs(activeSkill.activeEffect.grantedEffect.weaponTypes) do
            activeTypeLookup[activeType] = true
        end
    end

    if not next(activeTypeLookup) then
        return false
    end
    ...
end

Windburst does not appear to define weaponTypes, while Nightblade defines Claw/Dagger weapon types.

As a result, the function returns false before the actual equipped weapon can make the combination valid.

How to reproduce the issue

Equip a Claw or Dagger.
Add a skill setup that grants/triggers Windburst.
Add Nightblade Support to the relevant support chain.
Select Windburst in the Calcs tab.
Observe that Nightblade has no effect on Windburst's crit-related stats/damage.
Remove/re-add Nightblade and observe no change.

PoB for PoE1 build code

eNqtXG1v4roS_rz9FRHSke7V2S0Qwksreo4ofZXaLRe6u_d-WpnEgM86MSd22nJW-9_v2M4blIBD6EpbcGaesWc847E9af_PN59aLzjkhAUXteZpo2bhwGUeCeYXtS_PN596tT__OOmPkFg8zS4jQuWTP04-9NVny0ckmDD3Bxa3IYuWgFCzXIo4_4x8fFGbuABbsyh-wVQ9eyH49ZF58Oj-cfQ0fq5ZUxR4RFzUPrMA1yyBwjkWX5P-tL5Df5YoEAvMgkf0FwtvmZfQpu0kWGt3FyhErsDhgxQ7iATTEkUYwVPEXRx4w6yPiglG9KE_omiFw4lAwuLw30VtAIpBc3yFfPgfOo9oBAzN5mm72-k2Oo1Wu-M4tfpO5sso5OIwhMkSYy9jOu30iihHIb6ezbAryAsehkQMFyhwc_KcU6fXPivi3sLROO3ajn3W3sXyGFFBlpTgMNfHbreI5e6dkEL0ZyYQvRpNMtyzU8fp9TqdZuus12vu5mMiG0YR5f08IALnRTRObbvXarUdp9ty9rCtW7NxetZstZxmt3fW6uzrWmmRw4hScLk1viLaMeY4fEECfMeIfsj8KQmwN3iZZ6q2T52zRsPp9uw2_Cqc3SFGTzM96cbIIxF_xCLEPDcVCs37iAI0ZNzATJJyhEPwWFGKYYJdBk5eVkZJzgcyw-aUpcYRM5TtzWHjuJ6Y0pUGPqxDY3AvM8oJi6ghpcjClF1IdYXfDKjG-O88YbPZKgwYgTDDyxPuwLvCL0yoNXXfeFXAub4bpZStHoSbs6bdbXS7dqFvjhYrTlxEH9Eb8SMfgvYz-oEzeZ0d82--EAGEqiLWVuHScENCXJ5ryKh3ANcCMV7I1iuOEiS4g1Rl4LoRZBerlMXZ6ZAGeoNV3j2XtPeBa-blX4JQBfpcctDZyTAG35PZyJRiQ45MROzB2eRs7BE1x0Esb2U2nAeM3cUt6BdEgUXMInaWROxWrKQ1Uqwk3KLYtiFDCTVJxgI1nZ7tYiqtqOsAh_PVZEEw9cpRJ10boqVBaJWKznMbKXxdXKlZk2ctrZRvKPTMlqCyvXpBPB-am53dCtPkZpMTU4yBwcObeXrxjoD9JfcDtBzbIPRZFBqaXBMbDSBZVnTqPMZe5JotY-m25pLCNtN0GCkX9JPSUqwDIZD744p5c2OlKSGlONb7N4mWS4gjcjaYAsgVE7J9kst8PnUMqJ9gKhv5tFxczQVk1MYC0nTBXMoGi_lY5JJfYjAZubGI1KCPECx8WAjU3v2R5bbvhcaBDZ7Rbk0RbuwgC_2NvULPF_I0hZejhtQoS4cKuxLi4J-VMf4auZGA68CDNAtcwVjGJsc2Mc_Eh0DK-RUSyPLiVPorCgkKRFOdT3GMQnfxAKa_QZROIRJc1PKt8tsGo53Ytl9XZ2Ly03OIsYUSD3clheqA_GIFzMMcMose7P1rFmyace68yz6LD9DuPTlYy0dcwOqj5xeX4l0ayaY7xBc3LPRRdlpmr51uxQBc7btQuBqsPwoIVX360P8yflAfPiyEWPLzev319fV0icSCzfAbLCCnLvPrS2CD0XziPwiln2Sn6wP4uZwP1I8CqidIfX0kyOv6m_SikMCgtRXqUgtKX1JN8sNEgnKLL9jrA55Ddn2LfRjrDFGOpb5nKKIC2h70OWIgh53sUGqJniXGBAttRkCSUZWFku15tZQKHzw8wBPdxC9X4EfJmeBa443MKrKzEeVuWRf-EyFKxEqqVls0FmsRL7Fy3GhRNJW9lQeqMvP2EmnyzHSQ9VnZjQRgVg-2AHE00PbZJB0i6vJUzIc-9CcGv6VsimgzEZFvtJPGFz1fpfG_4oD5t6sQWufYly2PWCAP3KJ-L0ARdamNupIJn3LUyvwjFGo1_50pwwqQH891RW7l6DckxqfBduOdZlwWBbEBEznpkOtVxxzPh28k8KbyTHb30NPJk6MvHrx68kgC5YaTyPcZzJwRrOUCcT-vm0207R0z0NCx1PFZrqlTCimioT7yDNvtn6fYHGT-mfEo-3omxsEjdjgVQHTgkB9VX7Xfw3JwRSBewqLjSr-Pz_2VG0myJEhEHOtDqW8YLVmgmpOoqPDyPj0GzYnVuTUejK9Prqla4xG1rtB8jsOTgT-N-AI-DEM0E9g7t6TQk1GIZ-Tt3PoJC9McnzdO278eGGTBA8_DnkzKdDrc200okysjwjQ_Sqgn0WwrNaTsIUYcezrZVblKq5BanvXL3H0iQvIjTnH3U2e3A85JHDTPLbtxEi8N59btJ_h3okL6GP99bnUaJ_c-MLhEPm2e_BRozs_dGO5XTs6_nMYnp_3v32TU1OOw9Dy3EuGW7qulOxtD4cRq3z2ln4_xr7T94wxM8hEpnfz6uVSq_gWa5Va3YQlmNVsNS1rN0vo1hnXBgFthO46CbXYtaeOysDQx91bspi2x7WbLSqfFugDN9JFL4__6yZU5fzXtvFb19LDU_FjnyswSM9prjDvtEA_kHcTvdvc32ecCW2YTSsUEyK3HckbETmqp6SGPUNpJ1FijsPdStPZSOHsp2nspOnspuu8p-ioUp3EpSzd2xjDIQygTKjBDCg553w8LOIjQUb6hP46mkLRBklIv4LBLc7RKczglOC4ZE9waTFecy6mhgkmpYW0FsKsCtKoCVNZBuypApwwApqKSEbbw2xX5WxX5nYr87Yr8ZfVfglwHB6tpTV7lYUZZPvtAPi2vip12ApUx2K3My0pN0bFcMJulRdhlRdiHqKOC6xVhHKMfrSNgOEfAaB8Bo3Oon1Qxjl4P28cS3ToWkHMsoKMN7SDzVHcb-whuYx_FTMew0DGMU8Eud5j6uFIesR3BrozQqozgVEZoV0YolVEwb2XpC71q2XUhjH0cmNZxYJzjwLSPA1PGUrA9fsGVtkDbEezKCKU3QZUltisjdMrma63KIp3SCIdNsgOieemQU4Jh4EcUH7JryVialVIG-1gbj86xgNrHAjra0PaEEX0QlZy-qzP35LrzK8Gv8UXpRITy2usfxpIbu1Zt19G8JPyvEig__S-55O2rux996hUso6T_PuHu92k0m8mqfsAVoXpX4frm5nr4fP_1Ou5pnkXdQnwPIn8qa9X17-xGfoJVLYrlMkrRkstriPjmUR6yxfcNFIhAWDTlmvqiJgesHl5hgQjlRmh3JH0XII-lcLJnJkjfQNMhkbEhD3T9hkMB-kifmkCNkCs2cfylrAnAnipQMYNRhffvRqWHJEuo5O27mcr1ew95KH0SPURcjJEwQ5Hnx-sgssVsKPf-EtENG8VtxnNG3jrLCc-3KEXIG-kldsmMuJrGcPIk9UFruklKUk0wLuk73eomo4nCCJdFW3nuuM1Iq-rtiQ2t6jaj-YVdtFrn1k0mzGmZ4DpA2swCWTxognRN8YBQeQezYdnPLFCTHdwvJTABfISAFtd3rAM-iQUOkycmSOAlIZlGYjMq5NqNdKUKl9fUJFuMxqJKc_OsqsVIr2vFqmvBKP_EMDZuQKgWE9akTCzPrNsMTRCnXmvq121GSkhqSNfGHzcaOYkKt4MXRrz3kWLzYWVAVVl5hH7J2snqMJvFlEaI6shtw1_itkJ2nbYUcX8RRN52VwORHlcNQTpeNYRnErgiCrERwPhdUjPemcpknGmJ39paHTceyp-WAx6MoIsWD2ZXNZXG8f8Kz1RKvGUBSB9Vw7phkBhCuqHeDqyINRFRcAXq3Q2VKWjPCA0CkjmWXnlLKU0HlfhNoPfxUj-oDgR5wZ1pAlqIlBYa32FExWLEGK0GuPkqlIEJCrHkuxLREgVegvZUJu0v1h4THEBVde2VfCeDV-olpBP-KofTrycbzf5nBjmShJatyZc-ZP7gPBZ-k79k_d8q6bfeprJgRuZxgZn-EpeYqU6mLWsloiOKXLxg1MNhvEmdLGAtnchtDn-3R91Gj-UwZN3QSA4wYWjtYZD1S6UYkoQmoe80z3pne3jSLCYdRqPp7BMUvxoCplS1MBlzt2EwpiRvS5ja-5jSqqhS2si_FmEiytXGh62eCBF9JnMcDmVxY47btJ9lxE5cps5hSk6m_HsSqUb2KXL91Z6M0badHQL9tJpLueMdopS9wighD_GxeZfV-VJG3nP20MdHC9nUaph08RuRSwv2lEKV_SaYznK93GdEefKwqZ9dipWvKeArsINOck3kZL1d16WeBGPssxfsXa4GlK5KzIjcX4YwmLDL9KWz9313jB2y3ERK3fIAtqwEt5w06SebfL2zTjEbJ3NCn2YqJwSDqGTxnQ2GERfMf2QepGk4VFurzcJoQQTF8thDvY4QvwagS6S3cOsT23T90Uud-iY_qoXMQsslDrzcuxZckADF-1YKrgXL0uvAe5HGfIZkg-eWvn5988_C_B9hOJf6

Screenshots