fix: vulkan validation layers

Author: hoffstadt-nasa

docs/changelog.txt

@@ -9,6 +9,7 @@ away, please see git history for details.
                       (draw)     add draw callbacks
                       (starter)  added reverse z depth buffer support (v1.3.0)
                       (graphics) fix draw_indexed multiple index buffers (v1.5.1)
+                      (graphics) fix new validation layer errors (v1.5.2)
 - v0.6.2 (2025-10-08) (draw) performance improvements
                       (draw) fix draw 3d plane issues
                       (draw) add text transforms

docs/version.txt

@@ -60,7 +60,7 @@ the API is complete. It just means we won't break what currently exists.
 * Draw Backend        v1.1.0 (pl_draw_backend_ext.h)
 * DXT                 v1.0.0 (pl_dxt_ext.h)
 * GPU Allocators      v1.0.0 (pl_gpu_allocators_ext.h)
-* Graphics            v1.5.1 (pl_graphics_ext.h)
+* Graphics            v1.5.2 (pl_graphics_ext.h)
 * Image               v1.0.0 (pl_image_ext.h)
 * Job                 v2.2.0 (pl_job_ext.h)
 * Atomics             v1.0.0 (pl_platform_ext.h)

extensions/pl_graphics_cpu.c

@@ -437,6 +437,11 @@ pl_set_texture_usage(plBlitEncoder* ptEncoder, plTextureHandle tHandle, plTextur
 {
 }
 
+void
+pl_set_texture_usage(plBlitEncoder* ptEncoder, plTextureHandle tHandle, plTextureUsage tNewUsage, plTextureUsage tOldUsage)
+{
+}
+
 void
 pl_bind_texture_to_memory(plDevice* ptDevice, plTextureHandle tHandle, const plDeviceMemoryAllocation* ptAllocation)
 {

extensions/pl_graphics_ext.c

@@ -1195,6 +1195,7 @@ pl_load_graphics_ext(plApiRegistryI* ptApiRegistry, bool bReload)
         .begin_blit_pass                        = pl_begin_blit_pass,
         .end_blit_pass                          = pl_end_blit_pass,
         .set_texture_usage                      = pl_set_texture_usage,
+        .set_texture_usage_ex                   = pl_set_texture_usage_ex,
         .draw_stream                            = pl_draw_stream,
         .draw                                   = pl_draw,
         .draw_indexed                           = pl_draw_indexed,

extensions/pl_graphics_ext.h

@@ -114,7 +114,7 @@ Index of this file:
 // [SECTION] apis
 //-----------------------------------------------------------------------------
 
-#define plGraphicsI_version {1, 5, 1}
+#define plGraphicsI_version {1, 5, 2}
 
 //-----------------------------------------------------------------------------
 // [SECTION] includes
@@ -410,6 +410,7 @@ typedef struct _plGraphicsI
     plBlitEncoder*   (*begin_blit_pass)                (plCommandBuffer*); // do not store
     void             (*end_blit_pass)                  (plBlitEncoder*);
     void             (*set_texture_usage)              (plBlitEncoder*, plTextureHandle, plTextureUsage tNewUsage, plTextureUsage tOldUsage);
+    void             (*set_texture_usage_ex)           (plBlitEncoder*, plTextureHandle, plTextureUsage tNewUsage, plTextureUsage tOldUsage, plPipelineStageFlags tNewStages, plPipelineStageFlags tOldStages);
     void             (*copy_buffer_to_texture)         (plBlitEncoder*, plBufferHandle, plTextureHandle, uint32_t regionCount, const plBufferImageCopy*);
     void             (*copy_texture_to_buffer)         (plBlitEncoder*, plTextureHandle, plBufferHandle, uint32_t regionCount, const plBufferImageCopy*);
     void             (*copy_texture)                   (plBlitEncoder*, plTextureHandle src, plTextureHandle dst, uint32_t regionCount, const plImageCopy*);

extensions/pl_graphics_metal.m

@@ -2294,6 +2294,11 @@
 {
 }
 
+void
+pl_set_texture_usage(plBlitEncoder* ptEncoder, plTextureHandle tHandle, plTextureUsage tNewUsage, plTextureUsage tOldUsage)
+{
+}
+
 static plBlitEncoder*
 pl_begin_blit_pass(plCommandBuffer* ptCmdBuffer)
 {

extensions/pl_graphics_vulkan.c

@@ -1356,6 +1356,30 @@ pl_set_texture_usage(plBlitEncoder* ptEncoder, plTextureHandle tHandle, plTextur
     pl__transition_image_layout(ptCmdBuffer->tCmdBuffer, ptVulkanTexture->tImage, pl__vulkan_layout(tOldUsage), pl__vulkan_layout(tNewUsage), tRange, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT);
 }
 
+void
+pl_set_texture_usage_ex(plBlitEncoder* ptEncoder, plTextureHandle tHandle, plTextureUsage tNewUsage, plTextureUsage tOldUsage, plPipelineStageFlags tNewStages, plPipelineStageFlags tOldStages)
+{
+    plCommandBuffer* ptCmdBuffer = ptEncoder->ptCommandBuffer;
+    plDevice* ptDevice = ptCmdBuffer->ptDevice;
+
+    plTexture* ptTexture = pl__get_texture(ptDevice, tHandle);
+    plVulkanTexture* ptVulkanTexture = &ptDevice->sbtTexturesHot[tHandle.uIndex];
+
+    VkImageAspectFlags tImageAspectFlags = ptTexture->tDesc.tUsage & PL_TEXTURE_USAGE_DEPTH_STENCIL_ATTACHMENT ? VK_IMAGE_ASPECT_DEPTH_BIT : VK_IMAGE_ASPECT_COLOR_BIT;
+
+    if (pl__format_has_stencil(pl__vulkan_format(ptTexture->tDesc.tFormat)))
+        tImageAspectFlags |= VK_IMAGE_ASPECT_STENCIL_BIT;
+
+    VkImageSubresourceRange tRange = {
+        .baseMipLevel   = 0,
+        .levelCount     = ptTexture->tDesc.uMips,
+        .baseArrayLayer = 0,
+        .layerCount     = ptTexture->tDesc.uLayers,
+        .aspectMask     = tImageAspectFlags
+    };
+    pl__transition_image_layout(ptCmdBuffer->tCmdBuffer, ptVulkanTexture->tImage, pl__vulkan_layout(tOldUsage), pl__vulkan_layout(tNewUsage), tRange, pl_vulkan_pipeline_stage_flags(tOldStages), pl_vulkan_pipeline_stage_flags(tNewStages));
+}
+
 void
 pl_bind_texture_to_memory(plDevice* ptDevice, plTextureHandle tHandle, const plDeviceMemoryAllocation* ptAllocation)
 {
@@ -4937,7 +4961,8 @@ pl__transition_image_layout(VkCommandBuffer tCommandBuffer, VkImage tImage, VkIm
         // Image will be read in a shader (sampler, input attachment)
         // Make sure any writes to the image have been finished
         if (tBarrier.srcAccessMask == 0)
-            tBarrier.srcAccessMask = VK_ACCESS_HOST_WRITE_BIT | VK_ACCESS_TRANSFER_WRITE_BIT;
+            tBarrier.srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT;
+            // tBarrier.srcAccessMask = VK_ACCESS_HOST_WRITE_BIT | VK_ACCESS_TRANSFER_WRITE_BIT;
         tBarrier.dstAccessMask = VK_ACCESS_SHADER_READ_BIT;
         break;
     default: