From edb9ac19122c38af4d15852ed03d5c9ec7c97868 Mon Sep 17 00:00:00 2001 From: rmarow Date: Thu, 12 Nov 2026 10:08:51 -0700 Subject: [PATCH 01/10] init --- .github/workflows/test.yml | 2 +- pyproject.toml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a510ea57..335740da 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,7 +23,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.11", "3.12"] + python-version: ["3.11", "3.12", "3.13", "3.14"] runs-on: ["ubuntu-latest", "macos-latest", "windows-latest"] steps: diff --git a/pyproject.toml b/pyproject.toml index 1e273d89..d3f5ee90 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -23,6 +23,8 @@ classifiers = [ "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", + "Programming Language :: Python :: 3.13", + "Programming Language :: Python :: 3.14", "Topic :: Scientific/Engineering", "Typing :: Typed", ] From e63c81a70b19a3687cce38d295b30bff8eda9bb7 Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 13:25:17 -0700 Subject: [PATCH 02/10] Ignore d1_common invalid escape SyntaxWarning in pytest This can be removed once it's fixed upstream in d1_python. --- pyproject.toml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index d3f5ee90..748a9b10 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -136,6 +136,11 @@ filterwarnings = [ # needs it to honor API_ROOT_PATH, so ignore the warning rather than change # routing. Category is UserWarning because FastAPIDeprecationWarning subclasses it. "ignore:The `root_path` parameter is deprecated:UserWarning", + # d1_common (dataone.libclient) uses a non-raw regex string (`b"^\s*$\n"`). + # Harmless SyntaxWarning, but "error" above escalates it to a SyntaxError at + # import time on Python >=3.14. Leading ".*" because 3.14 reworded the message. + # Remove once fixed upstream in d1_python. + "ignore:.*invalid escape sequence:SyntaxWarning", ] log_cli_level = "INFO" testpaths = [ From 63953f38861511a025c51f2a2baac1b1e398f98c Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 13:28:53 -0700 Subject: [PATCH 03/10] add 3.15 to ci test list --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 335740da..3db8bccd 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,7 +23,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.11", "3.12", "3.13", "3.14"] + python-version: ["3.11", "3.12", "3.13", "3.14", "3.15"] runs-on: ["ubuntu-latest", "macos-latest", "windows-latest"] steps: From e9008b6d6c81209d7085e95f2175629fe3ae1812 Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 16:10:34 -0700 Subject: [PATCH 04/10] Update minimum python version --- .readthedocs.yaml | 2 +- pyproject.toml | 8 +++----- src/ogdc_runner/__main__.py | 1 - 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.readthedocs.yaml b/.readthedocs.yaml index c9aefc20..2692182f 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -6,7 +6,7 @@ version: 2 build: os: ubuntu-22.04 tools: - python: "3.11" + python: "3.13" nodejs: "16" jobs: post_install: diff --git a/pyproject.toml b/pyproject.toml index 748a9b10..98c7b208 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -11,7 +11,7 @@ version = "0.4.2" description = "Defines OGDC recipe API(s) and submits recipes to OGDC for execution" readme = "README.md" license.file = "LICENSE" -requires-python = ">=3.11" +requires-python = ">=3.13" classifiers = [ "Development Status :: 1 - Planning", "Intended Audience :: Science/Research", @@ -21,8 +21,6 @@ classifiers = [ "Programming Language :: Python", "Programming Language :: Python :: 3", "Programming Language :: Python :: 3 :: Only", - "Programming Language :: Python :: 3.11", - "Programming Language :: Python :: 3.12", "Programming Language :: Python :: 3.13", "Programming Language :: Python :: 3.14", "Topic :: Scientific/Engineering", @@ -160,7 +158,7 @@ report.exclude_also = [ [tool.mypy] files = ["src", "tests"] -python_version = "3.11" +python_version = "3.13" warn_unused_configs = true strict = true enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"] @@ -194,7 +192,7 @@ ignore_missing_imports = true [tool.ruff] src = ["src"] -target-version = "py311" +target-version = "py313" [tool.ruff.lint] extend-select = [ diff --git a/src/ogdc_runner/__main__.py b/src/ogdc_runner/__main__.py index 8a2873d6..10b4a6ac 100644 --- a/src/ogdc_runner/__main__.py +++ b/src/ogdc_runner/__main__.py @@ -341,7 +341,6 @@ def validate_all_recipes(recipes_location: str, ref: str) -> None: def _download_output_for_workflow( config: Config, workflow_name: str, output_dir: Path ) -> None: - headers = {} if config.access_mode != "open": headers["Authorization"] = f"Bearer {_get_api_token(config)}" From 009bc4fb035ae233d2d4ead81bf0b979857ccf9e Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 16 Nov 2026 23:12:01 +0000 Subject: [PATCH 05/10] style: pre-commit fixes --- src/ogdc_runner/argo.py | 2 +- src/ogdc_runner/recipe.py | 2 +- src/ogdc_runner/service/db.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ogdc_runner/argo.py b/src/ogdc_runner/argo.py index dcf3c802..42851e3c 100644 --- a/src/ogdc_runner/argo.py +++ b/src/ogdc_runner/argo.py @@ -447,7 +447,7 @@ def OgdcWorkflow( name: str, archive_workflow: bool, **kwargs: Any, -) -> Generator[Workflow, None, None]: +) -> Generator[Workflow]: """Contexts manager that yields an argo workflow with configuration driven by `recipe_config`. kwargs: diff --git a/src/ogdc_runner/recipe.py b/src/ogdc_runner/recipe.py index 32aac1a2..cb985606 100644 --- a/src/ogdc_runner/recipe.py +++ b/src/ogdc_runner/recipe.py @@ -33,7 +33,7 @@ def stage_ogdc_recipe(recipe_location: str): # type: ignore[no-untyped-def] @contextmanager -def clone_recipes_repo(repo_url: str, ref: str = "main") -> Generator[Path, None, None]: +def clone_recipes_repo(repo_url: str, ref: str = "main") -> Generator[Path]: """Clone a git repository at a specific ref. Args: diff --git a/src/ogdc_runner/service/db.py b/src/ogdc_runner/service/db.py index b52abe3b..ab379bb7 100644 --- a/src/ogdc_runner/service/db.py +++ b/src/ogdc_runner/service/db.py @@ -42,7 +42,7 @@ def get_engine() -> sqlalchemy.engine.base.Engine: # Create a FastAPI dependency on the database session. -def _get_session() -> Generator[Session, None, None]: +def _get_session() -> Generator[Session]: """Yield a database session for FastAPI routes.""" with Session(get_engine()) as session: yield session From 705cfdd71e2fd9bbb54c91e72542a0659323fee8 Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 16:18:46 -0700 Subject: [PATCH 06/10] resolve pre-commit issues --- pyproject.toml | 2 +- src/ogdc_runner/workflow/viz_workflow.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 3b724e2e..4a01d64c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -235,7 +235,7 @@ isort.required-imports = ["from __future__ import annotations"] [tool.ruff.lint.per-file-ignores] "tests/**" = ["T20"] "noxfile.py" = ["T20"] -"**/recipe_config.py" = ["UP007"] +"**/recipe_config.py" = ["UP007", "UP040"] [tool.hatch.metadata] allow-direct-references = true diff --git a/src/ogdc_runner/workflow/viz_workflow.py b/src/ogdc_runner/workflow/viz_workflow.py index 21beba63..4a7fb595 100644 --- a/src/ogdc_runner/workflow/viz_workflow.py +++ b/src/ogdc_runner/workflow/viz_workflow.py @@ -4,7 +4,7 @@ import logging import os from collections.abc import Callable -from typing import Any, TypeAlias, cast +from typing import Any, cast from hera.workflows import ( DAG, @@ -52,8 +52,8 @@ # ruff: noqa: PLC0415 logger = logging.getLogger(__name__) -WorkflowTask: TypeAlias = Any -WorkflowScript: TypeAlias = Callable[..., WorkflowTask] +WorkflowTask = Any +WorkflowScript = Callable[..., WorkflowTask] # Viz worker container image. Override via VIZ_WORKFLOW_IMAGE env var. VIZ_WORKFLOW_IMAGE: str = os.environ.get( From e0b95e7b5498c1346be5c31ada1d0c9dae9dafde Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 16:22:01 -0700 Subject: [PATCH 07/10] update github ci tests --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7845064d..0a6334f5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,7 +23,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.11", "3.12", "3.13", "3.14", "3.15"] + python-version: ["3.13", "3.14", "3.15"] runs-on: ["ubuntu-latest", "macos-latest", "windows-latest"] steps: From 8861123795dc520b20ca9174e8043b7b200d2828 Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 16:25:08 -0700 Subject: [PATCH 08/10] fix old 3.12 reference --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0a6334f5..486234a2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -64,7 +64,7 @@ jobs: - uses: "actions/setup-python@v7" with: - python-version: "3.12" + python-version: "3.13" allow-prereleases: true - name: "Install docs packages" From 491e237c1e5c6c5b599d652b90febb8462b9faeb Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 16:54:29 -0700 Subject: [PATCH 09/10] cont. --- docs/conf.py | 1 + pyproject.toml | 6 ++---- src/ogdc_runner/models/recipe_config.py | 2 +- src/ogdc_runner/publish.py | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index a55d6cdc..ad382db4 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -83,6 +83,7 @@ # There is no other context except that warning ("py:class", "list[dict[str"), ("py:class", "botocore.client.S3"), + ("py:class", "botocore.client.BaseClient"), ("py:class", "fastapi.responses.StreamingResponse"), ] diff --git a/pyproject.toml b/pyproject.toml index 4a01d64c..448ff55f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -52,7 +52,7 @@ dependencies = [ # NOTE: "test" and "dev" are duplicated; why do we need both? test = [ - "mypy ~=1.10.0", + "mypy ~=1.15", "pytest >=6", "pytest-cov >=3", "pytest-order", @@ -183,9 +183,7 @@ module = [ "boto3", "botocore.exceptions", "botocore", - "botocore.config", - "botocore.response", - "botocore.stub", + "botocore.*", ] ignore_missing_imports = true diff --git a/src/ogdc_runner/models/recipe_config.py b/src/ogdc_runner/models/recipe_config.py index 1ed25f88..81e7b7d5 100644 --- a/src/ogdc_runner/models/recipe_config.py +++ b/src/ogdc_runner/models/recipe_config.py @@ -480,7 +480,7 @@ class RecipeConfig(RecipeMeta): # This is where the rest of the config was set from. recipe_directory: Path - @computed_field # type: ignore[misc] + @computed_field # type: ignore[prop-decorator] @cached_property def id(self) -> str: k8s_name = self.name.lower().replace(" ", "-") diff --git a/src/ogdc_runner/publish.py b/src/ogdc_runner/publish.py index 3be6bbaf..ae74380a 100644 --- a/src/ogdc_runner/publish.py +++ b/src/ogdc_runner/publish.py @@ -6,7 +6,7 @@ from functools import cache import boto3 -import botocore +from botocore.client import BaseClient from botocore.config import Config from botocore.exceptions import ClientError from hera.workflows import ( @@ -288,7 +288,7 @@ def get_s3_bucket() -> str: @cache -def get_s3_client() -> botocore.client.S3: +def get_s3_client() -> BaseClient: """Return an S3 client configured from the `S3_*` environment variables.""" s3_secret_access_key_id = os.environ.get("S3_SECRET_KEY_ID") s3_secret_access_key = os.environ.get("S3_SECRET_KEY_KEY") From 4edc5101939009a7aaebbd62c8fb3f72343e1b0d Mon Sep 17 00:00:00 2001 From: rmarow Date: Mon, 16 Nov 2026 17:55:35 -0700 Subject: [PATCH 10/10] remove inadvertent add --- pyproject.toml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 448ff55f..a20442f2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -130,10 +130,6 @@ filterwarnings = [ "ignore:Using `httpx` with `starlette.testclient` is deprecated:DeprecationWarning", # AnyIO deprecation alias "ignore:The anyio\\.abc\\.BlockingPortal alias is deprecated:DeprecationWarning", - # FastAPI deprecates `FastAPI(root_path=...)` (seen in 0.162). The app still - # needs it to honor API_ROOT_PATH, so ignore the warning rather than change - # routing. Category is UserWarning because FastAPIDeprecationWarning subclasses it. - "ignore:The `root_path` parameter is deprecated:UserWarning", # d1_common (dataone.libclient) uses a non-raw regex string (`b"^\s*$\n"`). # Harmless SyntaxWarning, but "error" above escalates it to a SyntaxError at # import time on Python >=3.14. Leading ".*" because 3.14 reworded the message.