Remove support for <remove> and <compatFile> with removeTargets enabled

Author: Rosalie241

Spore ModAPI Easy Installer/XmlInstallerWindow.xaml.cs

@@ -484,27 +484,15 @@ private void GetComponents()
                 else if (node.Name.ToLower() == "compatfile")
                 {
                     Debug.WriteLine("compatFile");
-                    CompatFiles.Add(GetComponentFromXmlNode(node, true));
-                }
-                else if (node.Name.ToLower() == "remove")
-                {
-                    List<string> inner = node.InnerText.Split('?').ToList();
-
-                    List<string> game = new List<string>();
-                    if (node.Attributes["game"] != null)
-                        game = node.Attributes["game"].Value.Split('?').ToList();
-                    else
-                        foreach (string s in inner)
-                            game.Add(string.Empty);
+                    var component = GetComponentFromXmlNode(node, true);
 
-
-
-                    Debug.WriteLine("remove");
-                    Removals.Add(new RemovalInfo()
+                    // we don't support compatFile with removeTargets set
+                    // anymore due to the fact it's dangerous for mods
+                    // to be able to remove files that aren't theirs
+                    if (!component.removeTargets)
                     {
-                        RemovalFileNames = inner,
-                        RemovalGames = game
-                    });
+                        CompatFiles.Add(component);
+                    }
                 }
             }
 

docs/_developers/modinfo.md

@@ -43,8 +43,6 @@ This page contains documentation regarding creating an XML Mod Identity for your
 				game="GalacticAdventures" defaultChecked="true">ToggleComponent.package</component>
 	<prerequisite game="GalacticAdventures">Component.package</prerequisite>
 	<prerequisite game="GalacticAdventures">PrerequisiteFile.package</prerequisite>
-	<remove game="GalacticAdventures">NothingActuallyStartsWithThis*</remove>
-	<remove game="Spore">*NothingActuallyEndsWithThis.package</remove>
 </mod>
 ```
 
@@ -120,17 +118,6 @@ The prerequisite tag identifies a mandatory part of your mod. Content specifies
 
 ---
 
-## \<remove\> tag
-
-The remove tag seeks and removes existing files. Content specifies the names of the files which are to be removed if they exist (separated by question marks).
-
-* **game**
-	* Controls where the remove's file(s) are expected to be. Unspecified or invalid values are treated as referring to the ModAPI Launcher Kit folder,
-		e.g. for ModAPI DLLs. Alternative values are "GalacticAdventures" for Spore Galactic Adventures Data folder, 
-		"Spore" for Core Spore Data folder. Value should have the same number of entries as the filenames, again separated by question marks.
-
----
-
 ## \<compatFile\> tag
 
 The compatFile tag adds files only if certain other files are already installed. Content specifies the names of the files in your mod which are to be installed if the target files are found (separated by question marks).
@@ -148,9 +135,6 @@ The compatFile tag adds files only if certain other files are already installed.
 		e.g. for ModAPI DLLs. Alternative values are "GalacticAdventures" for Spore Galactic Adventures Data folder, 
 		"Spore" for Core Spore Data folder. Value should have the same number of entries as the filenames, again separated by question marks.
 
-* **removeTargets**
-	* Boolean value, controls whether or not the compatFile's source file(s) are removed if the target file is installed. Unspecified or invalid values are treated as false.
-
 ---
 
 ## \<component\> tag