Skip to content

Commit dbbfbf5

Browse files
committed
fix(runtime): omit absent src attribute value
1 parent f643efd commit dbbfbf5

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

‎packages/runtime/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ import url, { src, srcSet } from './photo.jpg'
5252
import { getImageProps, getSourceProps } from '@srcset/runtime'
5353

5454
const { src: imgSrc, srcSet: imgSrcSet } = getImageProps(src, srcSet)
55-
// <img src={imgSrc} srcset={imgSrcSet}/>
55+
// <img src={imgSrc} srcSet={imgSrcSet}/>
5656

5757
const sources = getSourceProps(srcSet)
5858
// sources of <picture>, grouped by mime type and ordered by format efficiency

‎packages/runtime/src/attributes.ts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,14 @@ export interface ImageSrcProps {
5555
*/
5656
export function getImageProps(src: SrcSetEntry | undefined, srcSet: SrcSetEntry[] | string | undefined): ImageSrcProps {
5757
if (typeof srcSet === 'string') {
58-
return {
59-
src: src?.url,
60-
srcSet
61-
}
58+
return src
59+
? {
60+
src: src.url,
61+
srcSet
62+
}
63+
: {
64+
srcSet
65+
}
6266
}
6367

6468
if (!src) {

0 commit comments

Comments
 (0)