Skip to content

Commit 05fe717

Browse files
authored
fix: resolve typecheck errors across packages (#139)
* fix(react): add vite/client types to resolve import.meta.env errors * fix: use turbo for typecheck to respect task graph dependencies * fix(core): add missing @types/node for sdk and storage-file
1 parent 0501cb1 commit 05fe717

7 files changed

Lines changed: 8 additions & 2 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"dev:cli": "bun run apps/cli/src/main.ts",
6363
"test": "turbo run test",
6464
"test:release:bootstrap": "vitest run tests/release-bootstrap-smoke.test.ts",
65-
"typecheck": "bun run --filter='*' typecheck",
65+
"typecheck": "turbo run typecheck",
6666
"lint": "oxlint -c .oxlintrc.jsonc . --deny-warnings",
6767
"lint:fix": "oxlint -c .oxlintrc.jsonc --fix .",
6868
"changeset": "changeset",

‎packages/core/sdk/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
},
1616
"devDependencies": {
1717
"@effect/vitest": "catalog:",
18+
"@types/node": "catalog:",
1819
"vitest": "catalog:",
1920
"typescript": "catalog:"
2021
}

‎packages/core/sdk/tsconfig.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"declaration": true,
1212
"declarationMap": true,
1313
"sourceMap": true,
14+
"types": ["node"],
1415
"plugins": [
1516
{
1617
"name": "@effect/language-service"

‎packages/core/storage-file/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"@effect/experimental": "catalog:",
1616
"@effect/sql-sqlite-node": "catalog:",
1717
"@effect/vitest": "catalog:",
18+
"@types/node": "catalog:",
1819
"typescript": "catalog:",
1920
"vitest": "catalog:"
2021
},

‎packages/core/storage-file/tsconfig.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"declaration": true,
1212
"declarationMap": true,
1313
"sourceMap": true,
14+
"types": ["node"],
1415
"plugins": [
1516
{
1617
"name": "@effect/language-service",

‎packages/react/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
"@types/node": "catalog:",
4848
"hast-util-to-jsx-runtime": "^2.3.6",
4949
"tailwindcss": "catalog:",
50-
"typescript": "catalog:"
50+
"typescript": "catalog:",
51+
"vite": "catalog:"
5152
},
5253
"scripts": {
5354
"typecheck": "tsc --noEmit"

‎packages/react/tsconfig.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"declarationMap": true,
1313
"sourceMap": true,
1414
"jsx": "react-jsx",
15+
"types": ["vite/client"],
1516
"plugins": [
1617
{
1718
"name": "@effect/language-service"

0 commit comments

Comments
 (0)