Share IMAGES_PLACEHOLDERS from @weaverse/schema - #527
Merged
Merged
Conversation
|
Claude finished @hta218's task in 1m 40s —— View job Claude finished reviewing this PRTodo list
ReviewThis is a clean, well-scoped move. I verified the diff against Verified correct:
Minor, non-blocking nits:
No correctness, security, or style issues found. I was unable to execute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMAGES_PLACEHOLDERSwas defined only in@weaverse/hydrogen, so@weaverse/nextstorefronts could not import it. This PR moves the constant into@weaverse/schema. Both adapters alreadyexport * from '@weaverse/schema', so each now exposes it with no extra re-export. The values and their docs are unchanged, andimport { IMAGES_PLACEHOLDERS } from '@weaverse/hydrogen'still works.Changes
IMAGES_PLACEHOLDERSfrompackages/hydrogen/src/index.tstopackages/schema/src/images-placeholders.tsand export it from@weaverse/schema@weaverse/schemato0.15.0(was0.14.0) in@weaverse/hydrogenand@weaverse/next, and refreshpnpm-lock.yamlapi-reports/: the constant moves fromhydrogen.api.mdtoschema.api.md, and the runtime export report adds it to@weaverse/schemaand@weaverse/next.specs/2026-09-15--images-placeholders-in-schema/Why the pins move to 0.15.0
Internal
@weaverse/*dependencies resolve from npm.scripts/check-packed-packages.mjsonly uses the packed schema tarball when a package's pin equals the workspace schema version. With the old0.14.0pins, packed hydrogen and next would install a registry schema without the constant, and their runtime exports would no longer match the report.0.15.0is the current workspace version and is already on npm, sopnpm install --frozen-lockfilekeeps working.Release order (required)
A published
@weaverse/hydrogenpinned to a schema without the constant would dropIMAGES_PLACEHOLDERSfrom its public API. Publish in this order:@weaverse/schema0.15.0->0.16.0@weaverse/schemato0.16.0inpackages/hydrogen/package.jsonandpackages/next/package.jsonbefore building them@weaverse/nextprereleasepnpm installonce the new versions are on npm, then commit the lockfileVerification
biome ci .,pnpm run typecheck,pnpm run testandpnpm run package:checkpass locally.