fix(messaging): register EF Core and MongoDB messaging patterns through the shared helper (#1333)

[dlrivada]

Summary

EF Core and MongoDB hand-rolled their messaging-pattern registrations instead of using the shared helper in Encina.Messaging, and the copies had drifted. MongoDB never registered InboxPipelineBehavior<,>, so UseInbox silently skipped deduplication. Neither provider registered ISagaRunner or ISagaNotFoundDispatcher, so UseSagas threw at first resolution.

What changed

• Encina.Messaging: new public AddOutboxInboxSagaSchedulingServices<...>. It takes the four pattern flags and their option types separately, so a provider whose configuration type is not MessagingConfiguration can use it. AddMessagingServices<...>, used by the six ADO.NET and Dapper packages, now delegates to it with no behaviour change. PublicAPI.Unshipped.txt is updated.
• Encina.EntityFrameworkCore: Outbox, Inbox, Saga and Scheduling now register through the shared method. Its own DbContext-bound TransactionPipelineBehavior stays registered directly. It is a different class from the generic one in Encina.Messaging, and routing it through the full helper broke an existing test.
• Encina.MongoDB: both AddEncinaMongoDB overloads call the shared method through one private helper. EncinaMongoDbOptions exposes the same four option types.
• Tests:
  • EF Core and MongoDB DI tests build the provider with ValidateOnBuild and ValidateScopes. They assert that InboxPipelineBehavior<,> is present when UseInbox is on and absent when it is off, and that ISagaRunner and ISagaNotFoundDispatcher resolve when UseSagas is on. One test enables every pattern for completeness.
  • Guard tests cover the new public method.
• changelog.d/1333-messaging-registration.fixed.md and the knowledge record docs/knowledge/issues/1333.md.

Verification

• Release build of Encina.slnx: 0 warnings, 0 errors.
• Unit tests matching MongoDB or EntityFrameworkCore: 1726 passed. Messaging guard tests: 493 passed. Messaging, MongoDB and EF Core contract tests: 304 passed.
• The new DI tests fail on the old registrations. With only the three production files restored to their old content (stashed, not committed), 6 tests failed with the expected symptoms: InboxPipelineBehavior missing, and No service for type 'Encina.Messaging.Sagas.LowCeremony.ISagaRunner'. All pass again with the fix.
• dotnet format --verify-no-changes clean on changed files. changelog-fragments --check and knowledge-records --check OK.
• CRAP: the new method has a cyclomatic complexity of about 6, and the tests cover both branches of every condition. AddMessagingServices lost complexity.
• Self-review by adversarial-reviewer found one major and two minors, all fixed:
  • the major: no guard tests for the new public method;
  • an overstated claim in the knowledge record;
  • duplicated calls in the two MongoDB overloads.

Follow-ups

• [TEST] ADO.NET and Dapper DI tests do not prove the messaging registrations with ValidateOnBuild #1398: the ADO.NET and Dapper DI tests resolve ISagaRunner without ValidateOnBuild/ValidateScopes and check neither ISagaNotFoundDispatcher nor InboxPipelineBehavior.

Cross-cutting checklist (ADR-018)

This is a registration fix, with no new entity, store, behavior or integration. Registration completeness (AGENTS.md §3) is integrated, with a DI test per provider. The 12 functions are not applicable.

Fixes #1333

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: dlrivada/Encina/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 12fee738-747d-475e-a9da-fe8a290cfa8e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 79.64912% with 58 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...EntityFrameworkCore/ServiceCollectionExtensions.cs	70.6%	34 Missing and 8 partials ⚠️
....Messaging/MessagingServiceCollectionExtensions.cs	88.2%	6 Missing and 4 partials ⚠️
src/Encina.MongoDB/ServiceCollectionExtensions.cs	89.4%	3 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

[dlrivada]

The first CI run failed the blocking crap-gate on five registration methods (CRAP up to 61.6). 756103f splits them into single-concern private helpers, one per messaging pattern or feature block, with the same registrations, lifetimes and order. It also adds tests for the previously uncovered Recoverability and MongoDB repository branches; 7e3e354 fixes a test summary. Local run of the gate script on real coverage: "No changed method exceeds the CRAP threshold" (45 changed methods). Build 0 warnings; unit 3514/3515 and guard 1100/1101, where the single failure in each needs a Docker daemon and is unrelated; contract 304/304. An independent adversarial review confirmed every extracted block is a verbatim move. The duplicated blocks left in AddMessagingServicesCore are tracked in #1406. CodeRabbit is rate-limited; the adversarial reviews stand in for it (pr-cycle).