Repository navigation
Expand file tree
/
Copy pathprotocol_test.go
More file actions
522 lines (480 loc) · 15.9 KB
/
Copy pathprotocol_test.go
File metadata and controls
522 lines (480 loc) · 15.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
//go:build linux || darwin || dragonfly || freebsd || netbsd || openbsd || windows
package http3
import (
"errors"
"fmt"
stdhttp "net/http"
"net/url"
"sync"
"testing"
"time"
fib "github.com/lesismal/fib"
"github.com/lesismal/fib/http3/qpack"
"github.com/lesismal/fib/http3/quic"
"github.com/lesismal/fib/tlstest"
)
// rawConn is a bare QUIC connection to the server, for sending what a
// well-behaved client never would.
type rawConn struct {
mu sync.Mutex
qc *quic.Conn
handshake chan struct{}
closed chan error
resets chan uint64
// onStream, when set, is handed what arrives on the streams.
onStream func(s *quic.Stream, data []byte, fin bool)
// early holds what arrived before onStream was set: the server's
// control stream can come right after the handshake.
early []streamData
}
type streamData struct {
s *quic.Stream
data []byte
fin bool
}
// setOnStream sets onStream and hands it what arrived before, in order.
func (r *rawConn) setOnStream(f func(s *quic.Stream, data []byte, fin bool)) {
r.mu.Lock()
defer r.mu.Unlock()
r.onStream = f
for _, d := range r.early {
f(d.s, d.data, d.fin)
}
r.early = nil
}
func (r *rawConn) OnOpen(*fib.Connection) {}
func (r *rawConn) OnPriorityData(*fib.Connection, []byte) {}
func (r *rawConn) OnData(_ *fib.Connection, data []byte) {
r.mu.Lock()
qc := r.qc
r.mu.Unlock()
if qc != nil {
qc.HandleDatagram(data)
}
}
func (r *rawConn) OnClose(*fib.Connection, error) {}
type rawHandler struct{ r *rawConn }
func (h rawHandler) OnHandshake(*quic.Conn) { close(h.r.handshake) }
func (h rawHandler) OnStreamData(s *quic.Stream, data []byte, fin bool) {
h.r.mu.Lock()
onStream := h.r.onStream
if onStream == nil {
h.r.early = append(h.r.early, streamData{s, append([]byte(nil), data...), fin})
}
h.r.mu.Unlock()
if onStream != nil {
onStream(s, data, fin)
}
}
func (h rawHandler) OnStreamReset(_ *quic.Stream, code uint64) {
h.r.resets <- code
}
func (h rawHandler) OnStopSending(*quic.Stream, uint64) {}
func (h rawHandler) OnStreamsAvailable(*quic.Conn) {}
func (h rawHandler) OnClose(_ *quic.Conn, err error) { h.r.closed <- err }
func dialRaw(t *testing.T, base string) *rawConn {
t.Helper()
u, err := url.Parse(base)
if err != nil {
t.Fatal(err)
}
_, clientTLS, err := tlstest.Configs()
if err != nil {
t.Fatal(err)
}
clientTLS.NextProtos = []string{NextProto}
engine, err := fib.New(fib.DefaultConfig())
if err != nil {
t.Fatal(err)
}
runEngine(t, engine)
r := &rawConn{handshake: make(chan struct{}), closed: make(chan error, 1), resets: make(chan uint64, 16)}
dialed := make(chan error, 1)
err = engine.DialWithHandler("udp", "127.0.0.1:"+u.Port(), time.Second, r, func(fc *fib.Connection, err error) {
if err != nil {
dialed <- err
return
}
r.mu.Lock()
r.qc, err = quic.Dial(fc, fc.RemoteAddr(), quic.Config{TLSConfig: clientTLS}, rawHandler{r})
r.mu.Unlock()
dialed <- err
})
if err == nil {
err = <-dialed
}
if err != nil {
t.Fatal(err)
}
select {
case <-r.handshake:
case <-time.After(5 * time.Second):
t.Fatal("no handshake")
}
return r
}
// expectClose waits for the server to close the connection with code.
func (r *rawConn) expectClose(t *testing.T, code ErrorCode) {
t.Helper()
select {
case err := <-r.closed:
var appErr *quic.ApplicationError
if !errors.As(err, &appErr) || !appErr.Remote || ErrorCode(appErr.Code) != code {
t.Fatalf("closed with %v, want %v", err, code)
}
case <-time.After(5 * time.Second):
t.Fatalf("not closed, want %v", code)
}
}
func headersFrame(fields ...qpack.HeaderField) []byte {
block := append([]byte(nil), qpack.Prefix...)
for _, f := range fields {
block = qpack.AppendField(block, f.Name, f.Value, false)
}
return appendHeadersFrame(nil, block)
}
func TestDataBeforeHeaders(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
s, err := r.qc.OpenStream()
if err != nil {
t.Fatal(err)
}
_ = s.Write(append(appendFrameHeader(nil, frameData, 2), 'h', 'i'), true)
r.expectClose(t, ErrCodeFrameUnexpected)
}
func TestControlStreamWithoutSettings(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
s, err := r.qc.OpenUniStream()
if err != nil {
t.Fatal(err)
}
payload := quic.AppendVarint(nil, 0)
frame := append(appendFrameHeader(nil, frameGoAway, len(payload)), payload...)
_ = s.Write(append([]byte{streamControl}, frame...), false)
r.expectClose(t, ErrCodeMissingSettings)
}
func TestSecondControlStream(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
for i := 0; i < 2; i++ {
s, err := r.qc.OpenUniStream()
if err != nil {
t.Fatal(err)
}
_ = s.Write(appendSettings([]byte{streamControl}), false)
}
r.expectClose(t, ErrCodeStreamCreationError)
}
func TestMalformedRequestIsReset(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
s, err := r.qc.OpenStream()
if err != nil {
t.Fatal(err)
}
// No :path.
_ = s.Write(headersFrame(
qpack.HeaderField{Name: ":method", Value: "GET"},
qpack.HeaderField{Name: ":scheme", Value: "https"},
qpack.HeaderField{Name: ":authority", Value: "localhost"},
), true)
select {
case code := <-r.resets:
if ErrorCode(code) != ErrCodeMessageError {
t.Fatalf("reset with %v", ErrorCode(code))
}
case <-time.After(5 * time.Second):
t.Fatal("not reset")
}
}
func TestDynamicTableReferenceFails(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
s, err := r.qc.OpenStream()
if err != nil {
t.Fatal(err)
}
// A Required Insert Count of one refers to a table the server never
// allowed.
block := []byte{0x02, 0x00, 0x80}
_ = s.Write(appendHeadersFrame(nil, block), true)
r.expectClose(t, ErrCodeQPACKDecompressionFailed)
}
// rawServer is an HTTP/3 server written frame by frame, for the things a
// well-behaved peer never sends. It answers every request with a short
// response, and setup writes whatever the case needs on the control stream.
type rawServer struct {
mu sync.Mutex
control *quic.Stream
closed chan error
// setup writes the control stream's frames after SETTINGS.
setup func(control *quic.Stream)
// respond writes a response on a request stream. Like setup, it is set
// before the server starts, which reads it on its own goroutine.
respond func(r *rawServer, s *quic.Stream)
// onUni, when set, is handed what arrives on the client's
// unidirectional streams.
onUni func(s *quic.Stream, data []byte)
}
func (r *rawServer) OnHandshake(qc *quic.Conn) {
control, err := qc.OpenUniStream()
if err != nil {
return
}
r.mu.Lock()
r.control = control
r.mu.Unlock()
_ = control.Write(appendSettings([]byte{streamControl}), false)
if r.setup != nil {
r.setup(control)
}
}
func (r *rawServer) OnStreamData(s *quic.Stream, data []byte, fin bool) {
if !s.Bidirectional() && r.onUni != nil {
r.onUni(s, data)
}
if !fin || !s.Bidirectional() {
return
}
if r.respond != nil {
r.respond(r, s)
return
}
block := append([]byte(nil), qpack.Prefix...)
block = qpack.AppendField(block, ":status", "200", false)
_ = s.Write(appendHeadersFrame(nil, block), true)
}
func (r *rawServer) OnStreamReset(*quic.Stream, uint64) {}
func (r *rawServer) OnStopSending(*quic.Stream, uint64) {}
func (r *rawServer) OnStreamsAvailable(*quic.Conn) {}
func (r *rawServer) OnClose(_ *quic.Conn, err error) { r.closed <- err }
// rawServerHandler feeds the engine's datagrams to one QUIC connection.
type rawServerHandler struct {
t *testing.T
server *rawServer
config quic.Config
}
func (h *rawServerHandler) OnOpen(*fib.Connection) {}
func (h *rawServerHandler) OnPriorityData(*fib.Connection, []byte) {}
func (h *rawServerHandler) OnData(c *fib.Connection, data []byte) {
if qc, ok := c.Attachment().(*quic.Conn); ok {
qc.HandleDatagram(data)
return
}
if !quic.IsInitial(data) {
return
}
if qc := quic.Accept(c, c.RemoteAddr(), h.config, h.server, data); qc != nil {
c.SetAttachment(qc)
}
}
func (h *rawServerHandler) OnClose(c *fib.Connection, err error) {
if qc, ok := c.Attachment().(*quic.Conn); ok {
qc.Abort(err)
}
c.SetAttachment(nil)
}
// startRawServer serves HTTP/3 by hand and returns the server and its URL.
func startRawServer(t *testing.T, setup func(control *quic.Stream), respond func(r *rawServer, s *quic.Stream)) (*rawServer, string) {
t.Helper()
return startRawServerFor(t, &rawServer{setup: setup, respond: respond})
}
// startRawServerFor is startRawServer for a server set up beforehand.
func startRawServerFor(t *testing.T, server *rawServer) (*rawServer, string) {
t.Helper()
serverTLS, _, err := tlstest.Configs()
if err != nil {
t.Fatal(err)
}
server.closed = make(chan error, 4)
config := fib.DefaultConfig()
engine, err := fib.New(config, fib.Binding{Network: "udp", Addr: "127.0.0.1:0", Handler: &rawServerHandler{t: t, server: server,
config: quic.Config{TLSConfig: ConfigureTLS(serverTLS)}}})
if err != nil {
t.Fatal(err)
}
runEngine(t, engine)
addr, err := engine.LocalUDPAddr()
if err != nil {
t.Fatal(err)
}
return server, fmt.Sprintf("https://localhost:%d", addr.Port)
}
// expectClientCloses runs a request against a raw server and waits for the
// client to end the connection with code.
func expectClientCloses(t *testing.T, server *rawServer, url string, code ErrorCode) {
t.Helper()
client := newClient(t, nil)
done := make(chan struct{})
go func() {
defer close(done)
_, _ = client.Go(mustRequest(t, stdhttp.MethodGet, url+"/", nil)).Wait()
}()
select {
case err := <-server.closed:
var appErr *quic.ApplicationError
if !errors.As(err, &appErr) || !appErr.Remote || ErrorCode(appErr.Code) != code {
t.Fatalf("the client closed with %v, want %v", err, code)
}
case <-time.After(10 * time.Second):
t.Fatalf("the client did not close the connection with %v", code)
}
<-done
}
func controlFrame(typ uint64, payload []byte) []byte {
return append(appendFrameHeader(nil, typ, len(payload)), payload...)
}
// A server may not send MAX_PUSH_ID (RFC 9114 section 7.2.7).
func TestClientRejectsMaxPushID(t *testing.T) {
server, url := startRawServer(t, func(control *quic.Stream) {
_ = control.Write(controlFrame(frameMaxPushID, quic.AppendVarint(nil, 10)), false)
}, nil)
expectClientCloses(t, server, url, ErrCodeFrameUnexpected)
}
// Nothing was ever promised, so there is no push to cancel (RFC 9114
// section 7.2.3).
func TestClientRejectsCancelPush(t *testing.T) {
server, url := startRawServer(t, func(control *quic.Stream) {
_ = control.Write(controlFrame(frameCancelPush, quic.AppendVarint(nil, 0)), false)
}, nil)
expectClientCloses(t, server, url, ErrCodeIDError)
}
// A server's GOAWAY names a request stream, which a unidirectional stream
// identifier is not (RFC 9114 section 5.2).
func TestClientRejectsGoAwayOnAnotherStreamType(t *testing.T) {
server, url := startRawServer(t, func(control *quic.Stream) {
_ = control.Write(controlFrame(frameGoAway, quic.AppendVarint(nil, 3)), false)
}, nil)
expectClientCloses(t, server, url, ErrCodeIDError)
}
// GOAWAY may only lower the identifier it names (RFC 9114 section 5.2).
func TestClientRejectsRaisedGoAway(t *testing.T) {
server, url := startRawServer(t, func(control *quic.Stream) {
// Stream 0, the request this test sends, is below this one and so
// is served; the connection therefore stays open.
_ = control.Write(controlFrame(frameGoAway, quic.AppendVarint(nil, 4)), false)
}, func(r *rawServer, _ *quic.Stream) {
// The second GOAWAY goes out once the request is there, and raises
// what the first one named. The request itself is left unanswered.
r.mu.Lock()
control := r.control
r.mu.Unlock()
_ = control.Write(controlFrame(frameGoAway, quic.AppendVarint(nil, 8)), false)
})
expectClientCloses(t, server, url, ErrCodeIDError)
}
// This side allows no dynamic table, so the peer may not fill one (RFC 9204
// section 4.3).
func TestClientRejectsQPACKInsertion(t *testing.T) {
server, url := startRawServer(t, func(control *quic.Stream) {
qc := control.Conn()
encoder, err := qc.OpenUniStream()
if err != nil {
return
}
// An Insert With Literal Name instruction, which needs a table.
_ = encoder.Write([]byte{streamQPACKEncoder, 0x40 | 0x03, 'a', 'b', 'c', 0x00}, false)
}, nil)
expectClientCloses(t, server, url, ErrCodeQPACKEncoderStreamError)
}
// A response whose field section refers to the dynamic table cannot be
// decoded (RFC 9204 section 2.2).
func TestClientRejectsDynamicTableReference(t *testing.T) {
server, url := startRawServer(t, nil, func(_ *rawServer, s *quic.Stream) {
// A Required Insert Count of one refers to a table that is empty.
_ = s.Write(appendHeadersFrame(nil, []byte{0x02, 0x00, 0x80}), true)
})
expectClientCloses(t, server, url, ErrCodeQPACKDecompressionFailed)
}
// rawControl opens the client's control stream and sends its SETTINGS.
func (r *rawConn) rawControl(t *testing.T) *quic.Stream {
t.Helper()
s, err := r.qc.OpenUniStream()
if err != nil {
t.Fatal(err)
}
if err := s.Write(appendSettings([]byte{streamControl}), false); err != nil {
t.Fatal(err)
}
return s
}
// A client that never received a promise has no push to cancel (RFC 9114
// section 7.2.3).
func TestServerRejectsCancelPush(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
control := r.rawControl(t)
_ = control.Write(controlFrame(frameCancelPush, quic.AppendVarint(nil, 0)), false)
r.expectClose(t, ErrCodeIDError)
}
// MAX_PUSH_ID may only raise the limit it grants (RFC 9114 section 7.2.7).
func TestServerRejectsLoweredMaxPushID(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
control := r.rawControl(t)
_ = control.Write(controlFrame(frameMaxPushID, quic.AppendVarint(nil, 10)), false)
_ = control.Write(controlFrame(frameMaxPushID, quic.AppendVarint(nil, 4)), false)
r.expectClose(t, ErrCodeIDError)
}
// A client's GOAWAY may only lower the push ID it names (RFC 9114 section
// 5.2).
func TestServerRejectsRaisedGoAway(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
control := r.rawControl(t)
_ = control.Write(controlFrame(frameGoAway, quic.AppendVarint(nil, 0)), false)
_ = control.Write(controlFrame(frameGoAway, quic.AppendVarint(nil, 8)), false)
r.expectClose(t, ErrCodeIDError)
}
// The server allows no dynamic table, so a client may not fill one (RFC
// 9204 section 4.3).
func TestServerRejectsQPACKInsertion(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
encoder, err := r.qc.OpenUniStream()
if err != nil {
t.Fatal(err)
}
// Set Dynamic Table Capacity to something the server did not allow.
_ = encoder.Write([]byte{streamQPACKEncoder, 0x20 | 0x10}, false)
r.expectClose(t, ErrCodeQPACKEncoderStreamError)
}
// A request whose :authority and Host disagree is malformed (RFC 9114
// section 4.3.1).
func TestMalformedAuthorityIsReset(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
s, err := r.qc.OpenStream()
if err != nil {
t.Fatal(err)
}
_ = s.Write(headersFrame(
qpack.HeaderField{Name: ":method", Value: "GET"},
qpack.HeaderField{Name: ":scheme", Value: "https"},
qpack.HeaderField{Name: ":authority", Value: "localhost"},
qpack.HeaderField{Name: ":path", Value: "/"},
qpack.HeaderField{Name: "host", Value: "elsewhere"},
), true)
select {
case code := <-r.resets:
if ErrorCode(code) != ErrCodeMessageError {
t.Fatalf("reset with %v", ErrorCode(code))
}
case <-time.After(5 * time.Second):
t.Fatal("the request was served")
}
}
// A request for http or https has to name an authority one way or another
// (RFC 9114 section 4.3.1).
func TestMissingAuthorityIsReset(t *testing.T) {
r := dialRaw(t, startServer(t, Config{}, echo))
s, err := r.qc.OpenStream()
if err != nil {
t.Fatal(err)
}
_ = s.Write(headersFrame(
qpack.HeaderField{Name: ":method", Value: "GET"},
qpack.HeaderField{Name: ":scheme", Value: "https"},
qpack.HeaderField{Name: ":path", Value: "/"},
), true)
select {
case code := <-r.resets:
if ErrorCode(code) != ErrCodeMessageError {
t.Fatalf("reset with %v", ErrorCode(code))
}
case <-time.After(5 * time.Second):
t.Fatal("the request was served")
}
}