fix(aiomysql): Use correct span attributes for StreamedSpan

- Use DB_SYSTEM_NAME instead of DB_SYSTEM for StreamedSpan
- Use DB_NAMESPACE instead of DB_NAME for StreamedSpan
- Add DB_DRIVER_NAME attribute for both StreamedSpan and regular Span
- Follow asyncpg/sqlalchemy integration patterns

Author: tonal

sentry_sdk/integrations/aiomysql.py

@@ -175,7 +175,8 @@ async def _inner(self: "Connection") -> T:
             span_attributes: dict[str, Any] = {
                 "sentry.op": OP.DB,
                 "sentry.origin": AioMySQLIntegration.origin,
-                SPANDATA.DB_SYSTEM: "mysql",
+                SPANDATA.DB_SYSTEM_NAME: "mysql",
+                SPANDATA.DB_DRIVER_NAME: "aiomysql",
             }
             host = getattr(self, "host", None)
             if host is not None:
@@ -185,7 +186,7 @@ async def _inner(self: "Connection") -> T:
                 span_attributes[SPANDATA.SERVER_PORT] = port
             database = getattr(self, "db", None)
             if database is not None:
-                span_attributes[SPANDATA.DB_NAME] = database
+                span_attributes[SPANDATA.DB_NAMESPACE] = database
             user = getattr(self, "user", None)
             if user is not None:
                 span_attributes[SPANDATA.DB_USER] = user
@@ -222,7 +223,7 @@ async def _inner(self: "Connection") -> T:
 
 
 def _get_connect_data(conn: Any) -> dict[str, Any]:
-    data: dict[str, Any] = {SPANDATA.DB_SYSTEM: "mysql"}
+    data: dict[str, Any] = {SPANDATA.DB_SYSTEM: "mysql", SPANDATA.DB_DRIVER_NAME: "aiomysql"}
     host = getattr(conn, "host", None)
     if host is not None:
         data[SPANDATA.SERVER_ADDRESS] = host
@@ -240,22 +241,43 @@ def _get_connect_data(conn: Any) -> dict[str, Any]:
 
 def _set_db_data(span: Any, conn: Any) -> None:
     """Set database-related span data from connection object."""
-    set_value = span.set_attribute if isinstance(span, StreamedSpan) else span.set_data
-
-    set_value(SPANDATA.DB_SYSTEM, "mysql")
-
-    host = getattr(conn, "host", None)
-    if host is not None:
-        set_value(SPANDATA.SERVER_ADDRESS, host)
-
-    port = getattr(conn, "port", None)
-    if port is not None:
-        set_value(SPANDATA.SERVER_PORT, port)
-
-    database = getattr(conn, "db", None)
-    if database is not None:
-        set_value(SPANDATA.DB_NAME, database)
-
-    user = getattr(conn, "user", None)
-    if user is not None:
-        set_value(SPANDATA.DB_USER, user)
+    if isinstance(span, StreamedSpan):
+        span.set_attribute(SPANDATA.DB_SYSTEM_NAME, "mysql")
+        span.set_attribute(SPANDATA.DB_DRIVER_NAME, "aiomysql")
+
+        host = getattr(conn, "host", None)
+        if host is not None:
+            span.set_attribute(SPANDATA.SERVER_ADDRESS, host)
+
+        port = getattr(conn, "port", None)
+        if port is not None:
+            span.set_attribute(SPANDATA.SERVER_PORT, port)
+
+        database = getattr(conn, "db", None)
+        if database is not None:
+            span.set_attribute(SPANDATA.DB_NAMESPACE, database)
+
+        user = getattr(conn, "user", None)
+        if user is not None:
+            span.set_attribute(SPANDATA.DB_USER, user)
+    else:
+        # Remove this else block once we've completely migrated to streamed spans
+        # The use of deprecated attributes here is to ensure backwards compatibility
+        span.set_data(SPANDATA.DB_SYSTEM, "mysql")
+        span.set_data(SPANDATA.DB_DRIVER_NAME, "aiomysql")
+
+        host = getattr(conn, "host", None)
+        if host is not None:
+            span.set_data(SPANDATA.SERVER_ADDRESS, host)
+
+        port = getattr(conn, "port", None)
+        if port is not None:
+            span.set_data(SPANDATA.SERVER_PORT, port)
+
+        database = getattr(conn, "db", None)
+        if database is not None:
+            span.set_data(SPANDATA.DB_NAME, database)
+
+        user = getattr(conn, "user", None)
+        if user is not None:
+            span.set_data(SPANDATA.DB_USER, user)