Skip to content

Commit 07faa49

Browse files
committed
address review feedback
1 parent 4588ebd commit 07faa49

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

  • packages/gapic-generator
    • gapic/templates/%namespace/%name_%version/%sub/services/%service/transports
    • tests/integration/goldens/showcase/google/showcase_v1beta1/services/resumable_upload_service/transports

‎packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,12 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
387387
return _error()
388388
self._stubs['{{ method.transport_safe_name|snake_case }}'] = _ErrorStub()
389389
elif HAS_ASYNC_REST:
390+
# TODO(https://github.com/googleapis/google-cloud-python/issues/16268):
391+
# Resolve the credential type mismatch between {{ service.grpc_asyncio_transport_name }}
392+
# (where grpc_helpers_async.create_channel and the base transport's
393+
# google.auth.default() path use synchronous google.auth.credentials.Credentials)
394+
# and Async{{ service.name }}RestTransport (where AsyncAuthorizedSession
395+
# requires asynchronous google.auth.aio.credentials.Credentials).
390396
# Defer instantiating Async{{ service.name }}RestTransport until the
391397
# resumable upload RPC is called so that initializing
392398
# {{ service.grpc_asyncio_transport_name }} with synchronous

‎packages/gapic-generator/tests/integration/goldens/showcase/google/showcase_v1beta1/services/resumable_upload_service/transports/grpc_asyncio.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,12 @@ async def _error():
365365
return _error()
366366
self._stubs['upload_media'] = _ErrorStub()
367367
elif HAS_ASYNC_REST:
368+
# TODO(https://github.com/googleapis/google-cloud-python/issues/16268):
369+
# Resolve the credential type mismatch between ResumableUploadServiceGrpcAsyncIOTransport
370+
# (where grpc_helpers_async.create_channel and the base transport's
371+
# google.auth.default() path use synchronous google.auth.credentials.Credentials)
372+
# and AsyncResumableUploadServiceRestTransport (where AsyncAuthorizedSession
373+
# requires asynchronous google.auth.aio.credentials.Credentials).
368374
# Defer instantiating AsyncResumableUploadServiceRestTransport until the
369375
# resumable upload RPC is called so that initializing
370376
# ResumableUploadServiceGrpcAsyncIOTransport with synchronous

0 commit comments

Comments
 (0)