Skip to content

Commit 22afbe2

Browse files
committed
fix(sqlalchemy-bigquery): support WindowFunctionTest test name across SQLAlchemy versions
1 parent 6cfb37b commit 22afbe2

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎packages/sqlalchemy-bigquery/tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -644,6 +644,7 @@ def test_no_results_for_non_returning_insert(cls):
644644
PostCompileParamsTest
645645
) # BQ adds backticks to bind parameters, causing failure of tests TODO: fix this?
646646
del QuotedNameArgumentTest # Quotes aren't allowed in BigQuery table names.
647-
del (
648-
WindowFunctionTest.test_window_rows_between
649-
) # test expects BQ to return sorted results
647+
# Test expects BQ to return sorted results (renamed to _w_caching in SQLAlchemy 2.1+)
648+
for _test_name in ("test_window_rows_between", "test_window_rows_between_w_caching"):
649+
if hasattr(WindowFunctionTest, _test_name):
650+
delattr(WindowFunctionTest, _test_name)

0 commit comments

Comments
 (0)