Commit 522db0e
authored
ci(gapic-generator): add showcase canary job, span artifact upload, and isolate goldens from pre-commit (#18518)
### Problem
1. Pre-commit hooks run across the whole monorepo and risk reformatting
or modifying Bazel integration test golden files
(`packages/gapic-generator/tests/integration/goldens/`), causing false
positive diff failures in golden verification tests.
2. In monorepo CI, gapic-generator integration tests install
dependencies from PyPI rather than testing directly against local,
unpublished changes in sibling packages like `google-api-core`. Being
able to run showcase tests against local changes is critical for ongoing
work such as the observability work.
3. When running system tests in CI, there is currently no mechanism to
preserve and download raw output data (such as telemetry span dumps) to
debug result regressions or verify compliance artifacts.
### Solution
- Exclude `packages/gapic-generator/tests/integration/goldens/` from
`.pre-commit-config.yaml` to ensure golden files remain untouched by
repository-wide hooks.
- Add `showcase-canary` job to
`.github/workflows/gapic-generator-tests.yml` that runs Showcase
integration tests against the local monorepo `google-api-core` when
`INSTALL_LOCAL_CORE="true"`.
- Support the `INSTALL_LOCAL_CORE` environment variable in
`packages/gapic-generator/noxfile.py` to optionally install local core
in development and CI environments.
- Add an `Upload Raw Spans Artifact` step to both `showcase` and
`showcase-canary` jobs to upload `raw_spans_output.json` as a build
artifact.
### Notes for Reviewers
- This change is strictly focused on testing infrastructure and
repository hygiene.
- It does not modify any client generation code or generator templates.1 parent 5d57b25 commit 522db0e
4 files changed
Lines changed: 123 additions & 15 deletions
File tree
- .github/workflows
- packages/gapic-generator
- docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
145 | 207 | | |
146 | 208 | | |
147 | 209 | | |
| |||
210 | 272 | | |
211 | 273 | | |
212 | 274 | | |
213 | | - | |
| 275 | + | |
214 | 276 | | |
215 | 277 | | |
216 | 278 | | |
| |||
242 | 304 | | |
243 | 305 | | |
244 | 306 | | |
245 | | - | |
| 307 | + | |
246 | 308 | | |
247 | 309 | | |
248 | 310 | | |
| |||
287 | 349 | | |
288 | 350 | | |
289 | 351 | | |
290 | | - | |
| 352 | + | |
291 | 353 | | |
292 | 354 | | |
293 | 355 | | |
294 | 356 | | |
295 | 357 | | |
296 | | - | |
| 358 | + | |
297 | 359 | | |
298 | 360 | | |
299 | 361 | | |
| |||
314 | 376 | | |
315 | 377 | | |
316 | 378 | | |
317 | | - | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
23 | 22 | | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
| 27 | + | |
29 | 28 | | |
30 | 29 | | |
31 | | - | |
| 30 | + | |
32 | 31 | | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
401 | 401 | | |
402 | 402 | | |
403 | 403 | | |
404 | | - | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
405 | 409 | | |
406 | 410 | | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
407 | 421 | | |
408 | 422 | | |
409 | 423 | | |
| |||
431 | 445 | | |
432 | 446 | | |
433 | 447 | | |
434 | | - | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
435 | 453 | | |
436 | 454 | | |
437 | 455 | | |
438 | 456 | | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
439 | 467 | | |
440 | 468 | | |
441 | 469 | | |
| |||
498 | 526 | | |
499 | 527 | | |
500 | 528 | | |
501 | | - | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
502 | 536 | | |
503 | 537 | | |
504 | 538 | | |
| |||
0 commit comments