Repository navigation
lua: return absolute coordinates from PCSX.Helpers.UI.imageCoordinates - #2472
Conversation
Viewport scenes take ImGui coordinates, which are absolute when multi-viewports are enabled, and the renderer already offsets each viewport. Subtracting the viewport position here shifted every point by it. GetCursorScreenPos is the absolute cursor position, and also accounts for the window's scroll.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the main change: returning absolute coordinates from PCSX.Helpers.UI.imageCoordinates. |
| Description check | |
The description directly explains the coordinate bug, the multi-viewport behavior, the implementation change, and the measured results. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
tvg.getViewportScenepaints take ImGui coordinates, which are absolute with multi-viewports on. The renderer translates each viewport by minus its own position.imageCoordinatessubtracted the viewport position as well, so every point it returned was shifted by it. It now returnsGetCursorScreenPos()plus the scaled offset, which also stops ignoring the window's scroll (GetCursorPosadds it back).Measured under Xvfb with a window placed at (300, 200): with
-viewportsthe main viewport sat at (0, 112), the old helper returned (308, 118) and the absolute cursor was (308, 230). With-no-viewportsboth were (308, 230).