Repository navigation
Commit 249869e
authored
fix(trade): page history_executions through all has_more results (#591)
## Problem
`/v1/trade/execution/history` caps each response at 1000 records.
`history_executions` deserialized only the first page's `trades` and
returned it, so any window with >1000 fills was **silently truncated**
(reported in longbridge/longbridge-terminal#320).
## Change
`history_executions` now walks every page via the `page` query parameter
(1-based) until `has_more` is false, returning the complete set. Deduped
by `trade_id` as a guard; bounded to 1000 pages.
**Verified against production** (`openapi.longbridge.com`): on an
account with 122 fills, `page=1` returns all 122 while **`page=2`
returns empty** — confirming the gateway honors `page` (a page-ignoring
gateway would return the same 122 for page=2). Response shape is `data:
{ has_more, trades[] }`.
Public signature unchanged (`GetHistoryExecutionsOptions` →
`Vec<Execution>`). The blocking wrapper and all language bindings
delegate to this method, so they get complete results for free — no
per-binding change.
## Testing
`cargo build` + `cargo clippy` clean. Live-verified `page` semantics
against production.
Refs longbridge/longbridge-terminal#3201 parent 0621e3f commit 249869e
3 files changed
Lines changed: 54 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
| 217 | + | |
| 218 | + | |
217 | 219 | | |
218 | 220 | | |
| 221 | + | |
| 222 | + | |
219 | 223 | | |
220 | 224 | | |
221 | 225 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
233 | 261 | | |
234 | 262 | | |
235 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
| |||
56 | 60 | | |
57 | 61 | | |
58 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
59 | 73 | | |
0 commit comments