Allow override of configured option on command line

[403-err]

Is it possible to allow command line "-d" option to override the config file? I have DaysOld="3" in the config file and could override it with -d1 on the command line, but this no longer seems to work.

It can be useful (for me) to override the waiting period if I'm doing updates manually.

[mag37]

Oh you're correct it have changed!

-C Temporarily use default configs - override dockcheck.config file.

When introducing that option the config file is sourced after the the CLI options and overriding them.
Though now thinking about it I agree - the CLI options should always override any config file options. I'll have to look into that later, sorry for the inconvenience.

For now, what you could do is shuck a -C into the command to not load the config at all - though that means no options from config.

[mag37]

So I've tried to wrap my head around this (while driving some 500km) and just tested an idea briefly.

If we move up the Source helper function and the sourcing of the config file to before the getops (CLI options parsing),
And change the check from [[ "${DefaultConfig:-false}" == false ]] to [[ ! ${ScriptArgs[*]} =~ "-C" ]].

That way the sourcing the config file (or not sourcing, with -C) happens earlier and CLI options will override the config.

Something like:

...} # end of Help() printer function

# Source helper function
source_if_exists_or_fail() {
  if [[ -s "$1" ]]; then
    source "$1"
    # DisplaySourcedFiles used for debugging purposes only
    [[ "${DisplaySourcedFiles:-false}" == true ]] && echo " * sourced config: ${1}"
    return 0
  else
    return 1
  fi
}

# Source user customizable config file prior to CLI options (if no -C option is passed)
if [[ ! ${ScriptArgs[*]} =~ "-C" ]]; then 
  source_if_exists_or_fail "${HOME}/.config/dockcheck.config" || source_if_exists_or_fail "${ScriptWorkDir}/dockcheck.config"
fi

while getopts ... # etc  onwards

[mag37]

Created a branch - I've briefly tested it but seems to do what it should:
https://github.com/mag37/dockcheck/tree/rearrange_sourcing

[403-err]

I tried the branch, it does what I expect for my use case.
Thanx

What are you thoughts on merging this back?

[mag37]

Thank you for testing!

I'll merge it to main when I'm back home early next week, but shouldn't be any issues and will be a part of the next version tag. Will reply here too.

[mag37]

@403-err
It's now merged to main. Thank you for raising the discussion! Would've missed it otherwise.