Description
The assert unary_red_code in _EQUIVALENT_NON_NAN_OPS on line 42 is used to validate a function argument, not an internal invariant. When Python runs with the -O (optimize) flag, assert statements are stripped entirely. If a caller passes an invalid unary_red_code, the function will silently fall through to _EQUIVALENT_NON_NAN_OPS[unary_red_code] and raise a bare KeyError with no context about what went wrong or which inputs were invalid. For library code, argument validation should use explicit if/raise so it is never stripped by the interpreter. This also contradicts the project's own style guide ("Errors: try/except with raise").
Severity: medium
File: cupynumeric/_module/_unary_red_utils.py
Expected Behavior
The code should handle this case properly to avoid unexpected errors or degraded quality.
Description
The
assert unary_red_code in _EQUIVALENT_NON_NAN_OPSon line 42 is used to validate a function argument, not an internal invariant. When Python runs with the-O(optimize) flag,assertstatements are stripped entirely. If a caller passes an invalidunary_red_code, the function will silently fall through to_EQUIVALENT_NON_NAN_OPS[unary_red_code]and raise a bareKeyErrorwith no context about what went wrong or which inputs were invalid. For library code, argument validation should use explicit if/raise so it is never stripped by the interpreter. This also contradicts the project's own style guide ("Errors: try/except with raise").Severity:
mediumFile:
cupynumeric/_module/_unary_red_utils.pyExpected Behavior
The code should handle this case properly to avoid unexpected errors or degraded quality.