Skip to content

Tachyon flamegraph times use the wrong units #154033

Description

@pablogsal

Tachyon flamegraphs report times that depend on the sampling rate.

For example, a function that sleeps for 400 ms is shown as 0.40 ms at 1 kHz and 0.04 ms at 100 Hz. The profile duration and percentages are correct.

The flamegraph values are sample counts, but the HTML divides them by 1000 and labels the result as milliseconds. We should account for sample_interval_usec when converting samples to time.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytopic-profilingtype-bugAn unexpected behavior, bug, or error

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions