[TypeDeclaration] Prefer same-namespace classes over global PHPDoc types (#8869)

Author: MohannadElemary

rules-tests/Renaming/Rector/Name/RenameClassRector/Fixture/skip_docblock_same_namespace_class.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Fixture;
+
+final class SkipDocblockSameNamespaceClass
+{
+    /**
+     * @param Countable $countable
+     * @param \Countable $global
+     * @return array<Countable>
+     */
+    public function run($countable, $global)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Fixture;
+
+final class SkipDocblockSameNamespaceClass
+{
+    /**
+     * @param Countable $countable
+     * @param \stdClass $global
+     * @return array<Countable>
+     */
+    public function run($countable, $global)
+    {
+    }
+}
+
+?>

rules-tests/Renaming/Rector/Name/RenameClassRector/Source/Countable.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Fixture;
+
+final class Countable
+{
+}

rules/TypeDeclaration/PHPStan/ObjectTypeSpecifier.php

@@ -64,6 +64,16 @@ public function narrowToFullyQualifiedOrAliasedObjectType(
             }
         }
 
+        // a class in the current namespace wins over a global class with the same short name
+        $namespaceName = $scope?->getNamespace();
+        $isUnqualified = ! $withPreslash && ! str_contains($className, '\\');
+        if ($namespaceName !== null && $isUnqualified) {
+            $namespacedClassName = $namespaceName . '\\' . $className;
+            if ($this->reflectionProvider->hasClass($namespacedClassName)) {
+                return new FullyQualifiedObjectType($namespacedClassName);
+            }
+        }
+
         if ($this->reflectionProvider->hasClass($className)) {
             // keep the scope class reflection of the current class, as it is refreshed on class change,
             // while the reflection provider one still reads the original file
@@ -76,10 +86,8 @@ public function narrowToFullyQualifiedOrAliasedObjectType(
         }
 
         // probably in same namespace
-        $namespaceName = null;
         if ($scope instanceof Scope) {
-            $namespaceName = $scope->getNamespace();
-            if ($namespaceName !== null) {
+            if ($namespaceName !== null && ! $isUnqualified) {
                 $newClassName = $namespaceName . '\\' . $className;
                 if ($this->reflectionProvider->hasClass($newClassName)) {
                     return new FullyQualifiedObjectType($newClassName);