Deprecate FunctionArgumentDefaultValueReplacerRector in favor of dedicated rules (#8692)

Author: TomasVotruba

config/set/php-version-based.php

@@ -7,9 +7,7 @@
 use PhpParser\Node\Expr\Cast\Int_;
 use PhpParser\Node\Expr\Cast\String_;
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;
-use Rector\Arguments\Rector\FuncCall\FunctionArgumentDefaultValueReplacerRector;
 use Rector\Arguments\ValueObject\ArgumentAdder;
-use Rector\Arguments\ValueObject\ReplaceFuncCallArgumentDefaultValue;
 use Rector\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector;
 use Rector\CodingStyle\Rector\ArrowFunction\ArrowFunctionDelegatingCallToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\Closure\ClosureDelegatingCallToFirstClassCallableRector;
@@ -95,6 +93,8 @@
 use Rector\Php80\Rector\ClassMethod\FinalPrivateToPrivateVisibilityRector;
 use Rector\Php80\Rector\ClassMethod\SetStateToStaticRector;
 use Rector\Php80\Rector\FuncCall\ClassOnObjectRector;
+use Rector\Php80\Rector\FuncCall\GetHeadersArgumentFormatRector;
+use Rector\Php80\Rector\FuncCall\VersionCompareFuncCallArgumentRector;
 use Rector\Php80\Rector\Identical\StrEndsWithRector;
 use Rector\Php80\Rector\Identical\StrStartsWithRector;
 use Rector\Php80\Rector\NotIdentical\StrContainsRector;
@@ -270,6 +270,8 @@
         ClassOnThisVariableObjectRector::class,
         ConsistentImplodeRector::class,
         OptionalParametersAfterRequiredRector::class,
+        VersionCompareFuncCallArgumentRector::class,
+        GetHeadersArgumentFormatRector::class,
 
         // PHP 8.1
         ReturnNeverTypeRector::class,
@@ -468,18 +470,6 @@
         'pg_setclientencoding' => 'pg_set_client_encoding',
     ], PhpVersion::PHP_80);
 
-    $rectorConfig->ruleWithConfigurationPhpVersionBound(FunctionArgumentDefaultValueReplacerRector::class, [
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'gte', 'ge'),
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'lte', 'le'),
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, '', '!='),
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, '!', '!='),
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'g', 'gt'),
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'l', 'lt'),
-        new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'n', 'ne'),
-        new ReplaceFuncCallArgumentDefaultValue('get_headers', 1, 0, false),
-        new ReplaceFuncCallArgumentDefaultValue('get_headers', 1, 1, true),
-    ], PhpVersion::PHP_80);
-
     // PHP 8.5
     $rectorConfig->ruleWithConfigurationPhpVersionBound(RemoveFuncCallArgRector::class, [
         // https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_key_length_parameter_of_openssl_pkey_derive

config/set/php80.php

@@ -3,9 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;
-use Rector\Arguments\Rector\FuncCall\FunctionArgumentDefaultValueReplacerRector;
 use Rector\Arguments\ValueObject\ArgumentAdder;
-use Rector\Arguments\ValueObject\ReplaceFuncCallArgumentDefaultValue;
 use Rector\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector;
 use Rector\CodingStyle\Rector\FuncCall\ConsistentImplodeRector;
 use Rector\Config\RectorConfig;
@@ -18,6 +16,8 @@
 use Rector\Php80\Rector\ClassMethod\FinalPrivateToPrivateVisibilityRector;
 use Rector\Php80\Rector\ClassMethod\SetStateToStaticRector;
 use Rector\Php80\Rector\FuncCall\ClassOnObjectRector;
+use Rector\Php80\Rector\FuncCall\GetHeadersArgumentFormatRector;
+use Rector\Php80\Rector\FuncCall\VersionCompareFuncCallArgumentRector;
 use Rector\Php80\Rector\Identical\StrEndsWithRector;
 use Rector\Php80\Rector\Identical\StrStartsWithRector;
 use Rector\Php80\Rector\NotIdentical\StrContainsRector;
@@ -47,6 +47,8 @@
         ClassOnThisVariableObjectRector::class,
         ConsistentImplodeRector::class,
         OptionalParametersAfterRequiredRector::class,
+        VersionCompareFuncCallArgumentRector::class,
+        GetHeadersArgumentFormatRector::class,
     ]);
 
     $rectorConfig
@@ -91,17 +93,4 @@
             'pg_result' => 'pg_fetch_result',
             'pg_setclientencoding' => 'pg_set_client_encoding',
         ]);
-
-    $rectorConfig
-        ->ruleWithConfiguration(FunctionArgumentDefaultValueReplacerRector::class, [
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'gte', 'ge'),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'lte', 'le'),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, '', '!='),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, '!', '!='),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'g', 'gt'),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'l', 'lt'),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'n', 'ne'),
-            new ReplaceFuncCallArgumentDefaultValue('get_headers', 1, 0, false),
-            new ReplaceFuncCallArgumentDefaultValue('get_headers', 1, 1, true),
-        ]);
 };

rules-tests/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector/Fixture/skip_first_class_callable.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\FuncCall\GetHeadersArgumentFormatRector\Fixture;
+
+class FormatArgument
+{
+    public function run($url)
+    {
+        get_headers($url, 0);
+        get_headers($url, 1);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\FuncCall\GetHeadersArgumentFormatRector\Fixture;
+
+class FormatArgument
+{
+    public function run($url)
+    {
+        get_headers($url, false);
+        get_headers($url, true);
+    }
+}
+
+?>

rules-tests/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector/Fixture/skip_version_compare.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\FuncCall\GetHeadersArgumentFormatRector\Fixture;
+
+class SkipGetHeaders
+{
+    public function run($url, $format)
+    {
+        get_headers($url);
+        get_headers($url, $format);
+        get_headers($url, true);
+        get_headers(...);
+    }
+}

rules-tests/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector/Fixture/some_function.php.inc

@@ -2,13 +2,13 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\Arguments\Rector\FuncCall\FunctionArgumentDefaultValueReplacerRector;
+namespace Rector\Tests\Php80\Rector\FuncCall\GetHeadersArgumentFormatRector;
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 
-final class FunctionArgumentDefaultValueReplacerRectorTest extends AbstractRectorTestCase
+final class GetHeadersArgumentFormatRectorTest extends AbstractRectorTestCase
 {
     #[DataProvider('provideData')]
     public function test(string $filePath): void