deprecate ReplaceArgumentDefaultValue value object, move shared sentinel to interface

Author: TomasVotruba

rules/Arguments/ArgumentDefaultValueReplacer.php

@@ -20,7 +20,6 @@
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use Rector\Arguments\Contract\ReplaceArgumentDefaultValueInterface;
-use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpParser\Node\NodeFactory;
@@ -63,7 +62,7 @@ public function processReplaces(
     private function isDefaultValueMatched(?Expr $expr, mixed $value): bool
     {
         // allow any values before, also allow param without default value
-        if ($value === ReplaceArgumentDefaultValue::ANY_VALUE_BEFORE) {
+        if ($value === ReplaceArgumentDefaultValueInterface::ANY_VALUE_BEFORE) {
             return true;
         }
 

rules/Arguments/Contract/ReplaceArgumentDefaultValueInterface.php

@@ -6,6 +6,8 @@
 
 interface ReplaceArgumentDefaultValueInterface
 {
+    public const string ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*';
+
     public function getPosition(): int;
 
     public function getValueBefore(): mixed;

rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php

@@ -9,12 +9,10 @@
 use Rector\Validation\RectorAssert;
 
 /**
- * @api used in rector-symfony
+ * @deprecated Use custom rule instead, see ReplaceArgumentDefaultValueRector deprecation.
  */
 final readonly class ReplaceArgumentDefaultValue implements ReplaceArgumentDefaultValueInterface
 {
-    public const string ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*';
-
     /**
      * @param int<0, max> $position
      */