[Proposal] Linguist, enry: Rename SaltStack language to Salt and update color

[jleroy]

Linguist and enry are programming language detection libraries used by a lot of softwares, especially software forges like GitHub (Linguist), Gitea and Forgejo (enry).

Currently, these library detects sls files as SaltStack and assign them the #646464 HTML color code. Example on GitHub repositories:

As SaltStack was the name of the now-defunct company behind Salt and the software/language itself is named Salt (although the two are often confused), I suggest to submit a PR to these projects to rename the language to Salt and take this opportunity to update the language color to #57bcad in order to match Salt Project’s official branding guidelines.

I already have a PR ready, but a public consensus within the community is needed for it to be accepted, hence this issue.
I’m not sure if this should be a discussion or an issue, so feel free to move it if needed. I think more people follow issues so more of them will have the opportunity to share their opinions here.

[whytewolf]

proper would be doing this on those libraries. this technically isn't something that should be handled in the salt repo. as there are other factors that have NOTHING to do with salt. such as if there are other programs with close color schemes that already exist.

not saying this shouldn't be discussed but i don't think this is the venue for it. and defiantly shouldn't be a issue in salt as there isn't a code change to make to this repo for it. a discussion maybe, that points to the libraries with existing PR's

[jleroy]

@whytewolf Sorry if I wasn't clear: I have a PR ready for these libraries, but Linguist requires a link to a public discussion in Salt’s community approving the changes to prevent some random guy from changing any language settings.
So I need a consensus here before submitting my PR.

[whytewolf]

let me rephrase what i said. This doesn't belong as an issue. it should be a discussion. issues are for if things need to change on THIS repo.

[jleroy]

OK no problem. If someone with write access to this repository can convert it to a discussion...

[whytewolf]

Ok. Now that is covered. I am all in favor of the change. Will need checking the colors are not already in use.

[jleroy]

I checked, and this color isn't being used in Linguist (enry uses the same metadata as Linguist).

[dafyddj]

I'm in favour of the proposed change.

[dwoz]

@jleroy are you willing to implement this?

[jleroy]

Yes, in fact everything is ready on my side.

[jleroy]

Since everyone seems OK with the proposed changes I plan to submit the PR to Linguist repository tomorrow.

[jleroy]

Done: github-linguist/linguist#8029

[jleroy]

Merged. The changes are expected to take effect on Github around September or October.