Skip to content

Add module/function lookup mcp tool - #323

Open
piotrsac wants to merge 5 commits into
mainfrom
piotrsaczawa/voy-339-mcp-module-and-function-lookup-tool-module_list
Open

piotrsac wants to merge 5 commits into
mainfrom
piotrsaczawa/voy-339-mcp-module-and-function-lookup-tool-module_list

Conversation

@piotrsac

@piotrsac piotrsac commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Tested on 10 Composer 2.5 agents with 10 different auto-prompts
9/10 succeeded on the first try, and the one that didn't get it in the first try corrected himself in another try, making all agents capable of using the tool.

@piotrsac
piotrsac added this pull request to stack #324 October 22, 2026 14:19
@piotrsac

Copy link
Copy Markdown
Member Author

@claude review

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @piotrsac's task in 55s —— View job


🦀 Review

Severity: 🔴 blocking · 🟡 should-fix · 🟢 nit

  • 🟢 65% lib/voyager/mcp/tools/module_list.ex:44: the blank check runs before String.trim/1, so a whitespace-only module fails with {:not_loaded, ""} instead of listing modules. Trim first and then match on "".

<verdict: 0 blocking, 0 should-fix, 1 nit>

Comment thread lib/voyager/mcp/tools/module_list.ex Resolved
@piotrsac
piotrsac marked this pull request as ready for review October 22, 2026 15:14
@piotrsac
piotrsac force-pushed the piotrsaczawa/voy-339-mcp-module-and-function-lookup-tool-module_list branch from c02e263 to 9f41d58 Compare October 22, 2026 15:14
@piotrsac

Copy link
Copy Markdown
Member Author

🦀 Review

Severity: 🔴 blocking · 🟡 should-fix · 🟢 nit

  • 🟢 75% README.md:85 — the MCP section lists every other tool and omits module_list, so the README no longer matches the server.

<verdict: 0 blocking, 0 should-fix, 1 nit>

@piotrsac
piotrsac force-pushed the piotrsaczawa/voy-339-mcp-module-and-function-lookup-tool-module_list branch from f86d536 to 2decca6 Compare October 28, 2026 19:56
Base automatically changed from piotrsaczawa/voy-326-module-and-function-catalog-cached to main October 30, 2026 15:30
@piotrsac
piotrsac force-pushed the piotrsaczawa/voy-339-mcp-module-and-function-lookup-tool-module_list branch from 2decca6 to 90257ea Compare October 30, 2026 15:30
@piotrsac

Copy link
Copy Markdown
Member Author

@claude review

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @piotrsac's task in 23s —— View job


🦀 Review

Severity: 🔴 blocking · 🟡 should-fix · 🟢 nit

No findings above the confidence threshold.

<verdict: 0 blocking, 0 should-fix, 0 nit>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant