Skip to content

feat: add C implementation for stats/base/dists/betaprime/quantile - #15388

Open
Planeshifter wants to merge 4 commits into
philipp/betaincinv-cfrom
philipp/betaprime-quantile-c
Open

feat: add C implementation for stats/base/dists/betaprime/quantile#15388
Planeshifter wants to merge 4 commits into
philipp/betaincinv-cfrom
philipp/betaprime-quantile-c

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Progresses stdlib-js/metr-issue-tracker#1235.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C/native implementation for @stdlib/stats/base/dists/betaprime/quantile

The C implementation delegates to @stdlib/math/base/special/betaincinv, mirroring the JavaScript implementation, and preserves parameter validation (NaN and nonpositive shape parameters), the x / (1 - x) transformation and its endpoint behavior (p = 0 yields 0 and p = 1 yields +infinity), and NaN behavior for out-of-domain probabilities.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code, with human review and verification of numerical parity against the JavaScript implementation.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Sep 21, 2026
@stdlib-bot

stdlib-bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/quantile $\\color{green}314/314$
$\\color{green}+0.00\\%$ 		$\\color{green}25/25$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}314/314$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review September 21, 2026 05:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 21, 2026
@Planeshifter Planeshifter mentioned this pull request Sep 21, 2026
Open
5 of 7 tasks
@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Sep 22, 2026
@stdlib-bot stdlib-bot added the Merge Conflicts Pull request which has merge conflicts. label Sep 24, 2026
@anandkaranubc anandkaranubc mentioned this pull request Oct 2, 2026
Open
@Planeshifter @anandkaranubc
feat: add C implementation for stats/base/dists/betaprime/quantile
f2abf71 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter @anandkaranubc
style: fix variable declaration order
8b9c85a 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
anandkaranubc force-pushed the philipp/betaprime-quantile-c branch from 50d553a to 8b9c85a Compare October 3, 2026 23:43
@anandkaranubc anandkaranubc added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. and removed Merge Conflicts Pull request which has merge conflicts. labels Oct 4, 2026
@anandkaranubc
anandkaranubc self-requested a review October 4, 2026 00:28
anandkaranubc
anandkaranubc approved these changes Oct 4, 2026
View reviewed changes

@anandkaranubc anandkaranubc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, @Planeshifter

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandkaranubc anandkaranubc anandkaranubc approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Planeshifter @stdlib-bot @anandkaranubc