Conversation
Migrate the test cases for `stats/incr/nanme` from relative tolerance assertions to ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bounds were tightened to the minimum passing integer values: `0` for the incremental accumulation test case and `3` for the test case asserting the current accumulated value. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSMKAZJRGKSu3kBXT9hJYU --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanmefrom relative tolerance assertions (delta <= tol, wheretol = C * EPS * abs( expected )) to ULP-based assertions using@stdlib/assert/is-almost-same-value, as proposed in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Two test cases were migrated, and, in each case, the ULP bound was tightened to the minimum passing integer value:
the accumulator function incrementally computes the mean error6.0 * EPS * abs( expected )0if not provided an input value, the accumulator function returns the current mean error3.0 * EPS * abs( expected )3The bounds were determined by starting from a high ULP allowance and lowering the value until the minimum passing integer was found. Lowering the second bound to
2causes that test case to fail, and0is already minimal for the first test case. The test suite was run twice at the final bounds in order to confirm determinism (16/16 assertions passing).Notes:
nulluntil a pair of non-NaNvalues has been provided.isAlmostSameValue( null, null, 0 )returnstrue, as the function short-circuits on strict equality for non-zero values, and thus the previousactual === expectedbranch is no longer necessary.test/test.jsrequired updating.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which performed the test migration, measured the minimum passing ULP bounds, and ran the test and lint suites locally.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01HSMKAZJRGKSu3kBXT9hJYU
Generated by Claude Code