Conversation
Replace computed relative tolerance comparisons with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of 2 ULPs for both the JavaScript and native implementations over the full 200-case fixture set. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjahTDGZsmsCpa2WPiWmGP
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/gamma/variancefrom relative tolerance testing to ULP difference testing, replacing the computeddelta/tolcomparisons with@stdlib/assert/is-almost-same-value.test/test.jsandtest/test.native.js.2.0 * EPS * abs( expected[ i ] ), so the bound is unchanged in spirit.Measurements were taken with the native add-on built locally, so the native implementation was exercised rather than skipped. Both implementations compute
alpha / ( beta*beta ), which involves no fused multiply-add opportunity, and the measured ULP difference was identical for the two across repeated runs.Only the two test files are changed.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The package test suite was run twice at the final ULP bound to confirm determinism (214 assertions passing in each of
test/test.jsandtest/test.native.json both runs), andmake lint-javascript-testsis clean for both files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which mirrored the migration idiom from previously merged conversions in the same family (e.g.
stats/base/dists/exponential/variance) and determined the minimum passing ULP bound empirically.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01VjahTDGZsmsCpa2WPiWmGP
Generated by Claude Code