Require both Redis connections explicitly; drop the $work fallback

No implicit "$commands defaults to $receive" — callers pass both connections,
which makes the two-connection model explicit and lets both be promoted. Pass
the same connection twice when one suffices (sequential/inline). All call sites
(workers, tests) updated accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: loks0n

src/Queue/Broker/Redis.php

@@ -14,9 +14,6 @@ class Redis implements Publisher, Consumer
     private const int RECONNECT_BACKOFF_MS = 100;
     private const int RECONNECT_MAX_BACKOFF_MS = 5_000;
 
-    /** Carries acks and publishing; wrap in Locking when shared by coroutines. */
-    private readonly Connection $commands;
-
     private bool $closed = false;
     private int $reconnectAttempt = 0;
     private int $reconnectBackoffMs = self::RECONNECT_BACKOFF_MS;
@@ -30,11 +27,11 @@ class Redis implements Publisher, Consumer
     private $reconnectSuccessCallback = null;
 
     public function __construct(
-        // Drives the blocking receive loop and its claim writes (single caller).
+        // Blocking receive loop + claim writes (single caller).
         private readonly Connection $receive,
-        ?Connection $commands = null,
+        // Acks and publishing; wrap in Locking when shared by coroutines.
+        private readonly Connection $commands,
     ) {
-        $this->commands = $commands ?? $receive;
     }
 
     public function setReconnectCallback(?callable $callback): self

tests/Queue/E2E/Adapter/PoolTest.php

@@ -15,7 +15,7 @@ class PoolTest extends Base
     protected function getPublisher(): Publisher
     {
         $pool = new UtopiaPool(new Stack(), 'redis', 1, function () {
-            return new RedisBroker(new Redis('redis', 6379));
+            return new RedisBroker(new Redis('redis', 6379), new Redis('redis', 6379));
         });
 
         return new Pool($pool, $pool);

tests/Queue/E2E/Adapter/RedisReconnectCallbackTest.php

@@ -13,7 +13,7 @@ public function testReconnectCallbackReceivesAttemptContext(): void
     {
         $queue = new Queue('reconnect-callback');
         $connection = new FailingRedisConnection();
-        $broker = new RedisBroker($connection);
+        $broker = new RedisBroker($connection, $connection);
         $calls = [];
 
         $broker->setReconnectCallback(function (Queue $queue, \Throwable $error, int $attempt, int $sleepMs) use (&$calls, $broker): void {
@@ -47,7 +47,7 @@ public function testReconnectSuccessCallbackReceivesAttemptCount(): void
     {
         $queue = new Queue('reconnect-success-callback');
         $connection = new RecoveringRedisConnection();
-        $broker = new RedisBroker($connection);
+        $broker = new RedisBroker($connection, $connection);
         $calls = [];
 
         $broker->setReconnectCallback(fn () => null);

tests/Queue/E2E/Adapter/SwooleConcurrencyTest.php

@@ -37,7 +37,7 @@ public function testOneCoroutineNeverOverlaps(): void
     private function runWorker(int $messages, int $maxCoroutines): array
     {
         $connection = new InMemoryConnection();
-        $broker = new Redis($connection);
+        $broker = new Redis($connection, $connection);
         $queue = new Queue(self::QUEUE, self::NAMESPACE);
 
         $active = 0;

tests/Queue/E2E/Adapter/SwooleRedisClusterTest.php

@@ -20,7 +20,7 @@ private function getConnection(): RedisCluster
 
     protected function getPublisher(): Publisher
     {
-        return new Redis($this->getConnection());
+        return new Redis($this->getConnection(), $this->getConnection());
     }
 
     protected function getQueue(): Queue

tests/Queue/E2E/Adapter/SwooleTest.php

@@ -16,7 +16,7 @@ private function getConnection(): Redis
 
     protected function getPublisher(): Publisher
     {
-        return new RedisBroker($this->getConnection());
+        return new RedisBroker($this->getConnection(), $this->getConnection());
     }
 
     protected function getQueue(): Queue

tests/Queue/E2E/Adapter/WorkermanTest.php

@@ -11,8 +11,7 @@ class WorkermanTest extends Base
 {
     protected function getPublisher(): Publisher
     {
-        $connection = new Redis('redis', 6379);
-        return new RedisPublisher($connection);
+        return new RedisPublisher(new Redis('redis', 6379), new Redis('redis', 6379));
     }
 
     protected function getQueue(): Queue

tests/Queue/servers/SwooleRedisCluster/worker.php

@@ -9,12 +9,14 @@
 use Utopia\Queue\Server;
 use Utopia\Validator\Text;
 
+$nodes = [
+    'redis-cluster-0:6379',
+    'redis-cluster-1:6379',
+    'redis-cluster-2:6379',
+];
 $consumer = new Redis(
-    new RedisCluster([
-        'redis-cluster-0:6379',
-        'redis-cluster-1:6379',
-        'redis-cluster-2:6379',
-    ]),
+    receive: new RedisCluster($nodes),
+    commands: new RedisCluster($nodes),
 );
 $adapter = new Swoole($consumer, 12, 'swoole-redis-cluster');
 $server = new Server($adapter);

tests/Queue/servers/Workerman/worker.php

@@ -9,7 +9,10 @@
 use Utopia\Queue\Broker\Redis;
 use Utopia\Validator\Text;
 
-$consumer = new Redis(new RedisConnection('redis'));
+$consumer = new Redis(
+    receive: new RedisConnection('redis'),
+    commands: new RedisConnection('redis'),
+);
 $adapter = new Workerman($consumer, 12, 'wokerman');
 $server = new Queue\Server($adapter);