Repository navigation
Move metadata to 0xdoublesharp and publish the crate with trusted publishing - #3
Merged
Merged
Conversation
check-docs.py recognized this repository's GitHub blob links only under /doublesharp/bin-packing/, so after a transfer it would skip them as external links instead of checking them locally, and it would stop re-pinning the binding READMEs to the release version. Both now take the owner and name from [workspace.package].repository, as release-note pinning already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The repository moved from doublesharp to the 0xdoublesharp organization. The workspace repository URL, both npm packages' repository URLs (napi create-npm-dirs copies the Node one into the six platform packages), the README images and links, the issue and pull request templates, the contributing guide and the v0.6.0 release notes now use the new owner. npm provenance requires repository.url to match the publishing repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The publish job read CARGO_REGISTRY_TOKEN from a secret for the whole job. It now gets a short-lived token from rust-lang/crates-io-auth-action (the job already has id-token: write) and passes it only to the cargo publish step. Authentication runs before the first publish step, so a missing crates.io trusted publisher stops the job before npm receives a partial release. The crate needs a trusted publisher for 0xdoublesharp/bin-packing and ci.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The repository moved from
doublesharpto the0xdoublesharporganization.scripts/check-docs.pyrecognized the repository's own GitHub blob links only under/doublesharp/bin-packing/. After the move it would have treated them as external links and skipped them, and it would have stopped re-pinning the binding READMEs to the release version. It now takes the owner and name from[workspace.package].repository, as release-note pinning already did. New tests cover both paths.repository, plusrepository.urlinbindings/nodeandbindings/wasm. In the publish job,napi create-npm-dirscopies the Node package'srepositoryinto the six platform packages (confirmed in@napi-rs/cli3.6.1's source), so they follow. npm provenance requires this URL to match the publishing repository.CONTRIBUTING.mdand the v0.6.0 release notes.CARGO_REGISTRY_TOKENno longer comes from a secret in the job-level env. Arust-lang/crates-io-auth-action@v1step runs before the first publish step (the job already hasid-token: write), and its short-lived token goes only tocargo publish. If the crates.io trusted publisher is missing, the job stops before npm receives a partial release.docs/releasing.mdis updated to match.Before the next release, the
bin-packingcrate needs a crates.io trusted publisher for0xdoublesharp/bin-packingand workflowci.yml.Verification
python3 -m unittest discover -s scripts/tests: 54 passed. The two new docs tests and the updated one fail against the old checker.python3 -B scripts/check-docs.py: generated docs and local links passed, and the new-owner links are now checked as local files.taplo fmt --check,typosandactionlintpassed.cargo metadata --no-deps --lockedshows the new repository URL../scripts/check-quality.sh(clippy, tests, doctests, Rust doc examples). No Rust sources changed, and CI's Quality gate runs the script on this PR.Checklist
and CONTRIBUTING.md.
./scripts/check-quality.shand recorded the result above. It runs in CI's Quality gate; see Verification.or explained why they do not apply.
or explained why they do not apply.
🤖 Generated with Claude Code