Fix table column layout when cells contain links - #5
Open
Obooman wants to merge 1 commit into
Open
Conversation
ProseMirror merges overlapping inline decorations into flat spans, so flex-on-source-spans split link cells into extra columns. Render concealed table rows via a real multi-cell widget instead; click a row to edit source. Also bump the landing SW cache and network-first JS/CSS. Co-authored-by: Oboo Cheng <oboochin@gmail.com>
Obooman
marked this pull request as ready for review
August 1, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the landing playground, README-style tables with links in cells looked broken: pipes/links split across extra columns instead of staying in a 2-column grid.
Root cause: ProseMirror merges overlapping inline decorations into flat spans (not nested). Putting
display:flexon the source row made each link fragment ([, label,](url), padding) its own flex item.Fix
.hm-table-visual) with proper columnsv2, network-first for JS/CSS so deploys are not masked by stale playground chunksTest
[docs/...](...)keeps exactly 2 visual columns per row