Repository navigation
Add a saftey check before deployment to the web server - #49
Merged
c-p-schmidt merged 1 commit intoSep 9, 2026
Merged
c-p-schmidt merged 1 commit into
c-p-schmidt merged 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new emptiness check can be bypassed if cd $LOCAL_DIR fails and currently exits without a diagnostic message, which can lead to unintended deployments and hard-to-debug failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a guardrail to the deployment workflow so the job fails when there’s nothing to deploy, preventing accidental “empty deploys” to the web server.
Changes:
- Add a local-directory emptiness check before running the
lftp mirrorupload. - Add brief inline comments describing the new safety check and the sync step.
File summaries
| File | Description |
|---|---|
| .github/workflows/deploy.yml | Adds a pre-deploy empty-directory check before syncing artifacts to the web server. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
to the server is empty. Sync it to the web server if not.
c-p-schmidt
force-pushed
the
add-check-that-src-directory-is-not-empty
branch
from
September 9, 2026 12:21
4994b1c to
25dbf14
Compare
maxiludwig
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail if the source directory to be synced to the server is empty. Sync it to the web server if not.