Skip to content

Added disordered trace grain data to grain_statistics.csv - #1376

Merged
tobyallwood merged 4 commits into
mainfrom
tobyallwood/missing-output-stats
Jul 14, 2026
Merged

tobyallwood merged 4 commits into
mainfrom
tobyallwood/missing-output-stats

Conversation

@tobyallwood

@tobyallwood tobyallwood commented Jul 8, 2026 •

Copy link
Copy Markdown
Collaborator

TopoStats Pull Requests

Closes #1371
Closes #1372

After the refactor some disordered trace data was collected but never saved to .csv, this PR rectifies that.
Documentation reflecting this has also been updated.

Further changes to the documentation have also been made; these changes are primarily focussed on ensuring the correct .csv names are referenced.


Before submitting a Pull Request please check the following.

  • Existing tests pass.
  • Pre-commit checks pass.

@SylviaWhittle SylviaWhittle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the failing tests that are a separate issue #1377, I think this is fine to just merge.

No time to do things properly and investigate if this messes with things as was discussed last week in the TopoStats meeting due to other time pressures.

@tobyallwood
tobyallwood added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit b80c8c5 Jul 14, 2026
1 of 7 checks passed
@tobyallwood
tobyallwood deleted the tobyallwood/missing-output-stats branch July 14, 2026 08:37
@ubdbra001 ubdbra001 mentioned this pull request Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Missing stats in grain_statistics.csv [bug]: "Data Dictionary" in new docs still describes outdated "all_statistics.csv"

2 participants