Repository navigation
Conversation
Follows up on the XPK recipe removals and Cluster Toolkit migrations (AI-Hypercomputer#389-AI-Hypercomputer#392) to clean up the remaining 20 residual XPK references across 11 files: - Fix broken relative link in training/ironwood/deepseek3-671b/4k-bf16-tpu7x-4x4x8/k8s/README.md pointing to deleted ../xpk/README.md#docker-container-image -> ../cluster_toolkit/README.md#docker-container-image - Remove legacy 'echo XPK Start/End' log lines from training/ironwood/wan2.1-14b/bf16-tpu7x-4x4x4/k8s/k8s_manifest.yaml - Reword KUEUE_QUEUE LocalQueue guidance across 7 Ironwood cluster_toolkit/README.md files to drop 'multislice-queue on a cluster provisioned with XPK' - Remove the internal-only 'UBench Run Name & BigQuery run_id' column (containing deprecated maxtext_training_with_xpk-* IDs and an internal LDAP) from the verified benchmark tables in the Ironwood and v5p Llama3.1-8B-LongContext-Maxtext cluster_toolkit/README.md files while preserving all configuration and performance metrics
There was a problem hiding this comment.
Code Review
This pull request updates documentation and configuration files across several model training directories. Key changes include removing the 'UBench Run Name & BigQuery run_id' column from performance tables in the READMEs, updating documentation links to point to the cluster toolkit instead of XPK, modifying the description of LocalQueues to refer to custom or shared GKE clusters, and removing XPK start/end timestamp logging from a Kubernetes manifest. There are no review comments to evaluate, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to the XPK deprecation cleanups and Cluster Toolkit migrations (#389, #390, #391, #392), this PR removes the remaining residual XPK references across
11training recipe files (0remainingxpkmatches in the repository):1file):training/ironwood/deepseek3-671b/4k-bf16-tpu7x-4x4x8/k8s/README.md: update theWORKLOAD_IMAGElink from deleted../xpk/README.md#docker-container-imageto[Docker container image](../cluster_toolkit/README.md#docker-container-image).1file):training/ironwood/wan2.1-14b/bf16-tpu7x-4x4x4/k8s/k8s_manifest.yaml: removeecho XPK Start: $(date);andecho XPK End: $(date);from the JobSet container launch command.KUEUE_QUEUELocalQueue prose (7files):training/ironwood/{llama3.1-405b/8k-fp8-tpu7x-4x8x8,llama3.1-70b/8k-fp8-tpu7x-4x4x4,llama3.1-70b/8k-bf16-tpu7x-4x8x8,llama3.1-70b/8k-fp8-tpu7x-4x8x8,llama3.1-70b/128k-fp8-tpu7x-4x8x8,qwen3-235b-a22b/4k-fp8-tpu7x-4x8x8,wan2.2-t2v-14b/bf16-tpu7x-2x4x4}/cluster_toolkit/README.md, reword theKUEUE_QUEUEexample from`multislice-queue` on a cluster provisioned with XPKtoon a custom or shared GKE cluster.2files):training/ironwood/Llama3.1-8B-LongContext-Maxtext/cluster_toolkit/README.mdandtraining/v5p/Llama3.1-8B-LongContext-Maxtext/cluster_toolkit/README.md: remove the internal-onlyUBench Run Name & BigQuery `run_id`column (which contained internal LDAP-prefixed run names and deprecatedmaxtext_training_with_xpk-*IDs rather than external links) while keeping all context lengths, parallelism/offload configurations, step times, throughputs, and MFU numbers intact.