Support multi-CVS mux/demux with per-sample-entry av2C configs - #9
Open
joelsole wants to merge 1 commit into
Open
Support multi-CVS mux/demux with per-sample-entry av2C configs#9joelsole wants to merge 1 commit into
joelsole wants to merge 1 commit into
Conversation
Emit a new stsd sample entry whenever a CVS boundary changes the Sequence Header, and re-inject each CVS's config OBUs on demux keyed by sample description index. Also patches a vendored libisomedia off-by-one (SampleToChunkAtom::lookupSample) that misattributed the first sample of a new stsc run to the previous sample description index, corrupting config-OBU reinjection at CVS boundaries. Verified byte-exact round-trip (MD5) across 18 single- and multi-CVS test streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a new stsd sample entry whenever a CVS boundary changes the Sequence Header, and re-inject each CVS's config OBUs on demux keyed by sample description index. Also patches a vendored libisomedia off-by-one (SampleToChunkAtom::lookupSample) that misattributed the first sample of a new stsc run to the previous sample description index, corrupting config-OBU reinjection at CVS boundaries.
Verified byte-exact round-trip (MD5) across 18 single- and multi-CVS test streams.