Repository navigation
Fix four bugs in the time-series workflow - #51
Merged
Merged
Conversation
orbitstatevectors.py stored state-vector times as seconds of day, dropping the date. A POEORB file spans ~26 h, so the time column wraps at midnight, and getburststatevectors.f90 took vectors from the day after the file's first midnight. For a 23:58 scene the ASF orbit service returns the file starting D 22:59:42, so the vectors came from D+1: the satellite was on the other side of the Earth, every GSLC was all zeros and no SBAS pairs passed the baseline cut (Lago-Yojoa a165). Store times as seconds since midnight of the acquisition date (from the SAFE name), so they never wrap, and search from the first vector. Scenes at other times select the same vectors as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
util/unwrap_parallel.py now checks that every .int has a .unw of the same size and exits 1 with the list of failed interferograms. Before, a failed unwrap (e.g. the snaphu 2.0-beta crash on Tacana a136, 26 of 655 interferograms) only showed up later as 'Non-existing record number' in regressheight/sbas. The snaphu crash itself is fixed by upgrading snaphu to 2.0.7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every non-S1A granule used the S1B offset (27), so stacks starting with an S1C scene got the wrong track number (e.g. a116 named _86_, a022 named _167_). Use a per-platform offset table: S1A 73, S1B 27, S1C 172. The S1C offset is verified on S1C granules of known track (95, 136, 22). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
phase is allocated (nr, naz, ncells), but the reference phase was read as phase(nr+ref_locs(1,k), ref_locs(2,k), i), left over from the older dat(2*nr, naz) layout. In column-major order nr+x spills into the next row, so every reference point was taken one row below the listed pixel. Checked on Jebel-at-Tair a116 (78 ref_locs): before, the time series averaged 0 one row below the ref_locs; after, it averages 0 at the ref_locs. The change is a constant per epoch (here up to 0.11 rad, ~0.5 mm). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yuankailiu
force-pushed
the
fix-hyp3-job-failures
branch
from
November 9, 2026 19:51
226b5db to
5dd565a
Compare
mfangaritav
approved these changes
Nov 14, 2026
mfangaritav
left a comment
Contributor
There was a problem hiding this comment.
snaphu has been updated to 2.0.7 in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while debugging failed time-series jobs on hyp3-lavas. Each commit fixes one bug and can be reviewed on its own.
1. Wrong orbit for scenes acquired just before midnight
sentinel/orbitstatevectors.pysaves orbit times without the date, so for scenes between 23:00 and 24:00 UTC the code picks the orbit from the next day.sentinel/orbitstatevectors.py,sentinel/getburststatevectors.f90). Scenes at other times are not affected. The a165 GSLCs need to be made again.2. Clear error when unwrapping fails
sbaswith an unclear error.util/unwrap_parallel.pynow stops right away with a list of the interferograms that failed to unwrap.so this PR does not change snaphu.3. Wrong track number for Sentinel-1C in product names
src/srg/time_series.pyused the Sentinel-1B formula for Sentinel-1C._86_).4. Reference point one row off
sbas/sbas.f90reads the reference phase one row below theref_locspoints.ref_locspoints.Testing
Not included: choosing reference points with
refpointsfromsim(hyp3-srg PR #161).