fix: escape verifier HTML fields - #13
Merged
royalpinto007 merged 1 commit intoSep 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Problem
The
/verify/pageendpoint interpolated receipt fields directly into HTML. A valid receipt containing HTML in its query or answer could therefore produce active markup, including script or event-handler elements, in the verification page.Changes
Tests
$env:PYTHONUTF8='1'; .venv/Scripts/python.exe -m pytest -q --basetemp .pytest-tmp(86 passed, Python 3.12)$env:PYTHONUTF8='1'; .venv311/Scripts/python.exe -m pytest -q --basetemp .pytest-tmp311(86 passed, Python 3.11).venv/Scripts/pytest.exe -q --basetemp .pytest-tmp tests/test_api.py::test_verify_page_escapes_receipt_fields(1 passed).venv/Scripts/ruff.exe check .python examples/demo_rag.py.venv/Scripts/python.exe -m compileall -q src testsuv build --out-dir .build-artifactsgit diff --checkCompatibility / Known limitations
Receipt signing, canonical serialization, verification results, and the JSON
/verifyendpoint are unchanged. Only the HTML representation escapes dynamic text before rendering. The local Windows environment requires UTF-8 mode for the repository's UTF-8 README fixture; CI runs on Linux.Issue link
Closes #11