fix: detect symlink cycles in collectFiles - #38
Merged
royalpinto007 merged 2 commits intoSep 12, 2026
Merged
Conversation
Track visited directory device/inode pairs so symlink loops cannot recurse indefinitely. Add tests for cyclic and benign directory symlinks. Fixes AgentPostmortem#10 Co-authored-by: Sharad. <sharadvc@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectFilesnow tracks visited directories bydev:inobefore recursing, so symlink cycles are skipped instead of walking untilELOOPor hanging. Per-entrystatSyncerrors are ignored so one bad symlink does not stop the scan.Test plan
npm test— cycle fixture finishes quickly; benign alias still yields scannable filesFixes #10