Skip to content

[O2B-1605] Use detectors rather than sync detectors as per inherited prop - #2213

Merged
graduta merged 2 commits into
mainfrom
improv/O2B-1605/use-detectors-inherited-prop
Aug 17, 2026
Merged

[O2B-1605] Use detectors rather than sync detectors as per inherited prop#2213
graduta merged 2 commits into
mainfrom
improv/O2B-1605/use-detectors-inherited-prop

Conversation

@graduta

@graduta graduta commented Aug 17, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • all runsPer* models now use the inherited detectors list

@graduta graduta self-assigned this Aug 17, 2026
@graduta
graduta requested a review from isaachilly as a code owner August 17, 2026 10:45
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.18%. Comparing base (86dde0e) to head (a759562).

Files with missing lines Patch % Lines
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 4 Missing ⚠️
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
+ Coverage   46.16%   46.18%   +0.01%     
==========================================
  Files        1040     1040              
  Lines       17163    17160       -3     
  Branches     3133     3133              
==========================================
+ Hits         7923     7925       +2     
+ Misses       9240     9235       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta
graduta merged commit 0eb8113 into main Aug 17, 2026
24 of 25 checks passed
@graduta
graduta deleted the improv/O2B-1605/use-detectors-inherited-prop branch August 17, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant