Fix of a hang in ITSClusterTask - #2680
Open
sawenzel wants to merge 1 commit into
Open
Conversation
This commit fixes a hang observed in the MC nightlies since 11. August 2026. The patch corrects upon findings of a debug session which surfaced that - ITSTracksClustersQC never returns. - It keeps its semaphore, so the other timeframes never run. - The QC finalisation stalls and the GRID watchdog kills the job. - The task aborts inside free() while it is destroyed. - The crash handler then deadlocks, so the process never exits. The destructor deletes the dcol maps in the inner barrel branch. For layers 0 to 2 this frees hDcolMapOBSor and hDcolMapOBEor at index -3, -2 and -1. They belong in the outer barrel branch. startOfCycle resets the same histograms without a null check. createAllHistos skips disabled layers, so they can be null. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sawenzel
requested review from
AlessandroSturniolo and
iravasen
as code owners
August 17, 2026 11:31
knopers8
approved these changes
Aug 17, 2026
knopers8
enabled auto-merge (squash)
August 17, 2026 12:04
Collaborator
|
thank you! |
AlessandroSturniolo
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a hang observed in the MC nightlies since 11. August 2026.
The patch corrects upon findings of a debug session which surfaced that
The destructor deletes the dcol maps in the inner barrel branch. For layers 0 to 2 this frees hDcolMapOBSor and hDcolMapOBEor at index -3, -2 and -1. They belong in the outer barrel branch.
startOfCycle resets the same histograms without a null check. createAllHistos skips disabled layers, so they can be null.