Skip to content

[OGUI-1745] ECS GUI Migration to new api/deploy endpoint - #3001

Merged
graduta merged 40 commits into
devfrom
feature/COG/OGUI-1675/front-end-migration-to-deploy-endpoint
Aug 19, 2025
Merged

[OGUI-1745] ECS GUI Migration to new api/deploy endpoint#3001
graduta merged 40 commits into
devfrom
feature/COG/OGUI-1675/front-end-migration-to-deploy-endpoint

Conversation

@graduta

@graduta graduta commented Aug 14, 2025

Copy link
Copy Markdown
Member

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • migrates the front-end to use the new api/deploy endpoint which now relies on kafka events for live updates
  • the front-end will now redirect the user to the env-details page rather than the page with all active environments
  • back-end introduces two new ECS GUI custom attributes for an environment:
    • isDeploying which is kept while the environment automatically transitions through ECS states until it reaches CONFIGURED with no other transition ongoing
    • deploymentError which is to be used to display environments that failed to deploy and await user's acknowledgement.
  • removes the hardcoded decoder of the proto objects to get the ID of environment in case of failure as the new deploy endpoint uses newEnvironmentAsync without an error in return but with errors followed as events via Kafka
  • removes the old request handler
  • adds general readme documentation for developers about the logic of deployment

@graduta
graduta requested a review from Copilot August 15, 2025 15:47

This comment was marked as outdated.

@graduta
graduta requested a review from Copilot August 18, 2025 10:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the ECS GUI front-end to use a new api/deploy endpoint that relies on Kafka events for live updates instead of the previous polling-based approach. The changes implement a more event-driven architecture for environment deployment and management.

  • Replaces the old environment creation workflow with a new async deployment endpoint
  • Introduces custom ECS GUI attributes (isDeploying, deploymentError) for better deployment state tracking
  • Redirects users to environment details page after deployment instead of the environments overview

Reviewed Changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Control/public/environment/Environment.js Updates environment creation logic to use new /api/deploy endpoint and redirect to environment details
Control/public/pages/Environments/Environments.page.js New environments page component with failed deployment acknowledgment functionality
Control/lib/services/Environment.service.js Updates environment service to handle deploying environments and deployment errors
Control/lib/controllers/Deployment.controller.js New deployment controller with acknowledgment endpoint
Control/lib/services/environment/EnvironmentCache.service.js Enhanced cache service with deployment state tracking and event handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Control/lib/services/environment/EnvironmentCache.service.js
Comment thread Control/lib/services/environment/EnvironmentCache.service.js
@graduta
graduta merged commit c92a7f4 into dev Aug 19, 2025
9 checks passed
@graduta
graduta deleted the feature/COG/OGUI-1675/front-end-migration-to-deploy-endpoint branch August 19, 2025 13:36
@graduta graduta changed the title [OGUI-1675] ECS GUI Migration to new api/deploy endpoint [OGUI-1745] ECS GUI Migration to new api/deploy endpoint Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants