feat: Implement partial text selection in chat messages - #177
Closed
devbreath wants to merge 1 commit into
Closed
Conversation
feat: Implement partial text selection in chat messages
This commit introduces the ability to select and copy a portion of text within chat messages, similar to other popular messengers.
Key changes include:
- Added a new preference setting ("Text selection in messages") to enable/disable the feature.
- Enabled `setTextIsSelectable(true)` on `ConversationItem`'s message body when the feature is active.
- Implemented a custom selection action mode callback to provide "Copy", "Select all", and "Share" options in the floating toolbar.
- Ensured that clickable links within message text remain functional even with text selection enabled.
- Coordinated with the existing multi-select mechanism by leveraging `TextView`'s inherent selection handling and `PassthroughClickListener`'s `hasSelection()` check.
- Skipped implementation for `QuoteView` (P1 requirement) in this initial phase.
No compilation errors were found. Further manual testing is required to validate full UX and gesture coordination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Implement partial text selection in chat messages
This commit introduces the ability to select and copy a portion of text within chat messages, similar to other popular messengers.
Key changes include:
setTextIsSelectable(true)onConversationItem's message body when the feature is active.TextView's inherent selection handling andPassthroughClickListener'shasSelection()check.QuoteView(P1 requirement) in this initial phase.No compilation errors were found. Further manual testing is required to validate full UX and gesture coordination.