fix(mobile): coalesce keyboard viewport settling - #194
Draft
Lint111 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coalesce the burst of mobile
visualViewportresize events into one final xterm layout and PTY resize after the software-keyboard animation settles.Root cause
Keyboard open and close used separate fixed 150 ms and 100 ms timers. Mobile browsers report several intermediate viewport heights during the OS animation, so those timers could fit xterm against a transient height and expose another layout/redraw before the final size arrived.
What changed
Commit structure
fix(mobile): coalesce keyboard viewport settlingValidation
test/mobile/keyboard.test.ts: 28 passed, 4 existing unrelated failuresnpm run typechecknpm run lintnpm run check:frontend-syntaxnpm run check:public-assetsnpm run buildgit diff --checkThe four existing failures are the stale toolbar-transform expectation, outdated accessory action list, and two local-input assertions. The new coalescing regression passes in that same run.
Scope
This PR does not change resize arbitration, mobile terminal controls, input handling, session replay, or authoritative frame capture.