Repository navigation
Incorrect type definitions for search #198
Description
Documentation for search says search takes an option string as second argument. However, the TS definition says the second argument is max_hits.
❯ pnpm why mupdf
mupdf@1.28.0
└── foo (dependencies)
Found 1 version of mupdf
❯ grep -n "search" node_modules/mupdf/dist/mupdf.d.ts
213: search(needle: string, max_hits?: number): Quad[][];
271: search(needle: string, max_hits?: number): Quad[][];
457: search(needle: string, max_hits?: number): Quad[][];
Activity
arun-mani-j commentedon Sep 6, 2026
It seems even the shipped code treats the second argument as
max_hitsonly 🤔artifex-tor commentedon Sep 6, 2026
A bug in 1.28.0. Upgrade to 1.28.1.
arun-mani-j commentedon Sep 6, 2026
Is 1.28.1 available at npm yet?
artifex-tor commentedon Sep 6, 2026
It is now!
arun-mani-j commentedon Sep 6, 2026