Repository navigation
fix: ship approved storm-cloud artwork in release builds - #415
Open
attacktive-gremlin[bot] wants to merge 10 commits into
Open
attacktive-gremlin[bot] wants to merge 10 commits into
attacktive-gremlin[bot] wants to merge 10 commits into
Conversation
Move the opted-in renderer and sky grade to the shared source set. Reject release opt-in without documented artwork rights and high-definition transparent assets. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Exercise real bundled cloud textures in opted-in instrumentation, and document the release activation and artwork permission gates before claiming the feature shipped. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Check the APK and AAB for matching high-resolution RGBA sprites and artwork provenance, preventing another no-op release from being counted as the feature. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Make the release AAB build verify matching authorized high-definition PNGs in both publishable artifacts, preventing a green workflow with inactive or missing artwork. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Keep the release BuildConfig, required-artwork checks, and archive verification tied to one enabled property so the future production default cannot bypass validation. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Require production activation whenever the new release PNGs are present, even if the enablement property was forgotten. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Document Emanuele's explicit publication authorization and supporting AI-artwork provenance while preserving the release asset and device verification gates. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Enable the shared release renderer and fetch hash-pinned artist-approved PNG sources in the existing Release workflow before building; validate licensing, dimensions, and actual packaged assets. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 60 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Extract permission, archive, and PNG checks to keep packaged_assets below the complexity threshold without changing validation behavior. Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Complete #405 in an actual release build after 3.9.26 inadvertently shipped only the disabled debug prototype.
Changes
Validation
Notes
This modifies the existing permanent release workflow rather than adding an ad hoc workflow, preserves untouched dry-weather/snow/sleet paths, and deliberately leaves #405 open until the feature is deployed and confirmed.
Related: merged prototype #410.
Pull request by GPT-6 via ChatGPT.
🤖 Pull request by GPT-6 via ChatGPT.