Skip to content

fix: ship approved storm-cloud artwork in release builds - #415

Open
attacktive-gremlin[bot] wants to merge 10 commits into
mainfrom
fix/storm-cloud-release-integration
Open

attacktive-gremlin[bot] wants to merge 10 commits into
mainfrom
fix/storm-cloud-release-integration

Conversation

@attacktive-gremlin

Copy link
Copy Markdown
Contributor

Purpose

Complete #405 in an actual release build after 3.9.26 inadvertently shipped only the disabled debug prototype.

Changes

  • Move the independently animated HD storm-cloud renderer and Natural rainy sky grade from debug-only code into shared code, removing release-only no-ops.
  • Enable storm clouds for release builds by default and preserve debug opt-in behavior.
  • Record Emanuele's explicit publication permission, his source/provenance explanation, and his supporting image.
  • Prepare the four reviewed, hash-verified RGBA cloud sprites in the existing tag-triggered release workflow. The source originals are never fetched at app runtime.
  • Fail production builds when enabled artwork or provenance is missing, or when the release renderer and packaged PNGs disagree.
  • Inspect the release APK and AAB for matching high-definition cloud PNGs.
  • Add real-sprite Android instrumentation coverage and packaging regression tests.

Validation

  • Connected Android instrumentation: Maintainer reports passing on November 6, 2026. Exact command, device and output have not been supplied here, so this is maintainer-reported rather than an independently reproduced run.
  • Python release packaging regression tests: 5 passed in previous local verification.
  • CI Test, CodeQL, and release build on this HEAD: pending confirmation.
  • Signed release APK/AAB content and real-device motion/landscape acceptance: not yet verified on this HEAD.
  • No update released by this PR. Do not announce Cloud Change Test Request #405 as available until the published release artifacts actually contain and activate the new renderer and sprites.

Notes

This modifies the existing permanent release workflow rather than adding an ad hoc workflow, preserves untouched dry-weather/snow/sleet paths, and deliberately leaves #405 open until the feature is deployed and confirmed.

Related: merged prototype #410.

Pull request by GPT-6 via ChatGPT.

🤖 Pull request by GPT-6 via ChatGPT.

attacktive-gremlin Bot and others added 9 commits November 6, 2026 04:49
Move the opted-in renderer and sky grade to the shared source set. Reject release opt-in without documented artwork rights and high-definition transparent assets.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Exercise real bundled cloud textures in opted-in instrumentation, and document the release activation and artwork permission gates before claiming the feature shipped.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Check the APK and AAB for matching high-resolution RGBA sprites and artwork provenance, preventing another no-op release from being counted as the feature.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Make the release AAB build verify matching authorized high-definition PNGs in both publishable artifacts, preventing a green workflow with inactive or missing artwork.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Keep the release BuildConfig, required-artwork checks, and archive verification tied to one enabled property so the future production default cannot bypass validation.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Require production activation whenever the new release PNGs are present, even if the enablement property was forgotten.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Document Emanuele's explicit publication authorization and supporting AI-artwork provenance while preserving the release asset and device verification gates.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
Enable the shared release renderer and fetch hash-pinned artist-approved PNG sources in the existing Release workflow before building; validate licensing, dimensions, and actual packaged assets.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
@codacy-production

codacy-production Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 60 complexity · 0 duplication

Metric Results
Complexity 60
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Extract permission, archive, and PNG checks to keep packaged_assets below the complexity threshold without changing validation behavior.

Co-authored-by: GPT-6 <267193182+codex@users.noreply.github.com>
@Attacktive Attacktive added bug Something isn't working graphics about clouds, fog, sun, rain, halos, scenery, sprite work, shaders/compositing, etc. labels Nov 6, 2026
@Attacktive Attacktive self-assigned this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working graphics about clouds, fog, sun, rain, halos, scenery, sprite work, shaders/compositing, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant